With plenty of CPP, build nix daemon on Windows too#15184
Open
Ericson2314 wants to merge 1 commit intoNixOS:masterfrom
Open
With plenty of CPP, build nix daemon on Windows too#15184Ericson2314 wants to merge 1 commit intoNixOS:masterfrom
Ericson2314 wants to merge 1 commit intoNixOS:masterfrom
Conversation
amaanq
force-pushed
the
nix-daemon-windows
branch
3 times, most recently
from
0fbb22d to
2d79127
Compare
Ericson2314
force-pushed
the
nix-daemon-windows
branch
from
2d79127 to
4952130
Compare
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 10, 2026
This commit extracts the Unix domain socket server loop (`PeerInfo`, `getPeerInfo`, and the systemd socket activation / poll / accept loop) from `src/nix/unix/daemon.cc` into a reusable `unix::serveUnixSocket` function in `libcmd`. Split out from NixOS#15184.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 10, 2026
This commit extracts the Unix domain socket server loop (`PeerInfo`, `getPeerInfo`, and the systemd socket activation / poll / accept loop) from `src/nix/unix/daemon.cc` into a reusable `unix::serveUnixSocket` function in `libcmd`. This is split out from NixOS#15184.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 10, 2026
This commit extracts the Unix domain socket server loop (`PeerInfo`, `getPeerInfo`, and the systemd socket activation / poll / accept loop) from `src/nix/unix/daemon.cc` into a reusable `unix::serveUnixSocket` function in `libcmd`. This is split out from NixOS#15184.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 10, 2026
This commit extracts the Unix domain socket server loop (`PeerInfo`, `getPeerInfo`, and the systemd socket activation / poll / accept loop) from `src/nix/unix/daemon.cc` into a reusable `unix::serveUnixSocket` function in `libcmd`. This is split out from NixOS#15184.
amaanq
added a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 10, 2026
This commit extracts the Unix domain socket server loop (`PeerInfo`, `getPeerInfo`, and the systemd socket activation / poll / accept loop) from `src/nix/unix/daemon.cc` into a reusable `unix::serveUnixSocket` function in `libcmd`. This is split out from NixOS#15184.
Ericson2314
force-pushed
the
nix-daemon-windows
branch
from
4952130 to
655e639
Compare
Ericson2314
pushed a commit
to obsidiansystems/nix
that referenced
this pull request
Feb 10, 2026
This commit extracts the Unix domain socket server loop (`PeerInfo`, `getPeerInfo`, and the systemd socket activation / poll / accept loop) from `src/nix/unix/daemon.cc` into a reusable `unix::serveUnixSocket` function in `libcmd`. This is split out from NixOS#15184.
Ericson2314
changed the title
serveUnixSocket, support on Windows too
Ericson2314
force-pushed
the
nix-daemon-windows
branch
from
655e639 to
7fdd3e8
Compare
Ericson2314
force-pushed
the
nix-daemon-windows
branch
from
7fdd3e8 to
25ee7b3
Compare
Windows does support Unix domain sockets now, somewhat. This isn't very maintainable, so the next commit will introduce an abstraction that will be useful for this, and other socket servers.
Ericson2314
force-pushed
the
nix-daemon-windows
branch
from
25ee7b3 to
6d34cfd
Compare
Member
Author
|
Ugh, no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
First commit adds windows support, second commit factors out the functions.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.