BuildError: set exit status by default#15154
Closed
amaanq wants to merge 1 commit intoNixOS:masterfrom
Closed
Conversation
amaanq
force-pushed
the
builderror-exit-status
branch
from
894fd7f to
a63af39
Compare
Ericson2314
approved these changes
Feb 5, 2026
auto-merge was automatically disabled
February 5, 2026 16:29
Head branch was pushed to by a user without write access
amaanq
force-pushed
the
builderror-exit-status
branch
from
a63af39 to
1b8617c
Compare
github-actions
bot
added
the
with-tests
amaanq
force-pushed
the
builderror-exit-status
branch
2 times, most recently
from
446583a to
40e2d91
Compare
This commit has `BuildError` compute its exit status by default from its `Status`. While exit codes may sometimes need to be recomputed (e.g., when combining multiple errors), this simplifies the common case. Co-authored-by: Amaan Qureshi <git@amaanq.com>
amaanq
force-pushed
the
builderror-exit-status
branch
from
40e2d91 to
236838d
Compare
Member
Author
|
Closing as we can't split this out from #15090 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This commit has
BuildErrorcompute its exit status by default from itsStatus. While exit codes may sometimes need to be recomputed (e.g., when combining multiple errors), this simplifies the common case.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.