worker-protocol: add cancelled-and-hash-mismatch-status feature#15090
Open
amaanq wants to merge 1 commit intoNixOS:masterfrom
Open
worker-protocol: add cancelled-and-hash-mismatch-status feature#15090amaanq wants to merge 1 commit intoNixOS:masterfrom
amaanq wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
new-cli
amaanq
force-pushed
the
hash-mismatch-fix
branch
2 times, most recently
from
7c26fed to
145c623
Compare
Ericson2314
reviewed
Jan 29, 2026
Ericson2314
reviewed
Jan 29, 2026
Ericson2314
reviewed
Jan 29, 2026
Ericson2314
reviewed
Jan 29, 2026
Ericson2314
reviewed
Jan 29, 2026
Ericson2314
reviewed
Jan 29, 2026
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
Please make a first PR that just introduces ExitStatusFlags (and does the things I mention below). Then we'll return to this one for the actual wire protocol changes using it.
|
🎉 All dependencies have been resolved ! |
Ericson2314
force-pushed
the
hash-mismatch-fix
branch
2 times, most recently
from
d2623b4 to
0c5cd3b
Compare
amaanq
force-pushed
the
hash-mismatch-fix
branch
from
0c5cd3b to
5956f56
Compare
amaanq
force-pushed
the
hash-mismatch-fix
branch
5 times, most recently
from
556da11 to
e4dbc59
Compare
Ericson2314
reviewed
Feb 6, 2026
amaanq
force-pushed
the
hash-mismatch-fix
branch
2 times, most recently
from
f48542e to
9b369ca
Compare
amaanq
force-pushed
the
hash-mismatch-fix
branch
2 times, most recently
from
ce832f0 to
433911c
Compare
Ericson2314
reviewed
Feb 6, 2026
Ericson2314
reviewed
Feb 6, 2026
Ericson2314
reviewed
Feb 6, 2026
Member
|
Let's just combine-in https://github.com/NixOS/nix/pull/14559/files |
amaanq
force-pushed
the
hash-mismatch-fix
branch
3 times, most recently
from
f2dfbe7 to
b8b6a14
Compare
Ericson2314
reviewed
Feb 6, 2026
Ericson2314
reviewed
Feb 6, 2026
amaanq
force-pushed
the
hash-mismatch-fix
branch
from
b8b6a14 to
377a372
Compare
Ericson2314
reviewed
Feb 6, 2026
Ericson2314
reviewed
Feb 6, 2026
Ericson2314
reviewed
Feb 6, 2026
Ericson2314
reviewed
Feb 6, 2026
| * Build result. | ||
| */ | ||
| BuildResult buildResult; | ||
| BuildResult buildResult = {.inner = BuildResult::Failure{BuildResult::Failure::Cancelled, ""}}; |
Member
There was a problem hiding this comment.
N.B. tempted to just change the default status on BuildResult itself, rather than here.
amaanq
force-pushed
the
hash-mismatch-fix
branch
from
377a372 to
e7bf1b1
Compare
xokdvium
reviewed
Feb 6, 2026
Comment on lines
+53
to
+57
| /// Goal was never attempted because another goal failed (and | ||
| /// `--keep-going` wasn't used). Requires the | ||
| /// `cancelled-and-hash-mismatch-status` feature; falls back to | ||
| /// `MiscFailure` when communicating with older remotes. | ||
| Cancelled, |
Contributor
There was a problem hiding this comment.
This should also handle Interrupted cases right?
Member
Member
Author
There was a problem hiding this comment.
I added the comment based on Eelco's PR description, I don't think handling Interrupted would make sense since it's not a BuildResult status but rather its own error that occurs on SIGINT, SIGTERM, and SIGHUP.
amaanq
force-pushed
the
hash-mismatch-fix
branch
3 times, most recently
from
939aa89 to
c948def
Compare
Ericson2314
reviewed
Feb 7, 2026
amaanq
force-pushed
the
hash-mismatch-fix
branch
2 times, most recently
from
0f6f3a6 to
abd4ec8
Compare
amaanq
changed the title
This commit adds a `cancelled-and-hash-mismatch-status` protocol feature that gates two new `BuildResult` failure statuses: `HashMismatch` (a specific type of `OutputRejected` for hash mismatches) and `Cancelled` (for goals never attempted because another goal failed without `--keep-going`). Goals now default to `Cancelled` status instead of `MiscFailure`. When communicating with older remotes, `HashMismatch` falls back to `OutputRejected` and `Cancelled` falls back to `MiscFailure`. Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
amaanq
force-pushed
the
hash-mismatch-fix
branch
from
abd4ec8 to
0b8349c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This commit adds a
cancelled-and-hash-mismatch-statusprotocol feature that gates two newBuildResultfailure statuses:HashMismatch(a specific type ofOutputRejectedfor hash mismatches) andCancelled(for goals never attempted because another goal failed without--keep-going). Goals now default toCancelledstatus instead ofMiscFailure. When communicating with older remotes,HashMismatchfalls back toOutputRejectedandCancelledfalls back toMiscFailure.Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.