Skip to content

libstore/s3-binary-cache-store: Add Content-MD5 header as message int… #15127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ericson2314 merged 1 commit into from
Feb 1, 2026
Merged

libstore/s3-binary-cache-store: Add Content-MD5 header as message int… #15127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/libstore/s3-binary-cache-store.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,20 @@ void S3BinaryCacheStore::upsertFile(
if (auto storageClass = s3Config->storageClass.get()) {
uploadHeaders.emplace_back("x-amz-storage-class", *storageClass);
}

{
HashSink hashSink(HashAlgorithm::MD5);
src.drainInto(hashSink);
auto [hash, gotLength] = hashSink.finish();
/* Use this opportunity to check that the upload size matches what we expect. */
if (gotLength != size)
throw Error("unexpected size for upload '%s', expected %d, got: %d", path, size, gotLength);
/* The Base64 encoded 128-bit MD5 digest of the message (without the headers) according to RFC 1864:
https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutObject.html */
uploadHeaders.push_back({"Content-MD5", hash.to_string(HashFormat::Base64, /*includeAlgo=*/false)});
src.restart(); /* Seek to the beginning. */
}

if (s3Config->multipartUpload && size > s3Config->multipartThreshold) {
uploadMultipart(path, src, size, mimeType, std::move(uploadHeaders));
} else {
Expand Down
Loading