libstore/s3-binary-cache-store: Add Content-MD5 header as message int…#15127
Merged
Ericson2314 merged 1 commit intomasterfrom Feb 1, 2026
Merged
libstore/s3-binary-cache-store: Add Content-MD5 header as message int…#15127Ericson2314 merged 1 commit intomasterfrom
Ericson2314 merged 1 commit intomasterfrom
Conversation
…egrity check aws-sdk-cpp used to include a checksum for uploads (CRC64 since ~September 2025). Content-MD5 [1] should be universally supported by all s3 compatible services, since the SDK used to include it unconditionally too. [1]: https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutObject.html
github-actions
bot
added
the
store
Ericson2314
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…egrity check
Motivation
aws-sdk-cpp used to include a checksum for uploads (CRC64 since ~September 2025).
Content-MD5 1 should be universally supported by all s3 compatible services, since the SDK used
to include it unconditionally too.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.