nix-profile.fish: $NIX_STATE_HOME: Warn about old .nix-profile#14810
Open
ilya-bobyr wants to merge 1 commit intoNixOS:masterfrom
Open
nix-profile.fish: $NIX_STATE_HOME: Warn about old .nix-profile#14810ilya-bobyr wants to merge 1 commit intoNixOS:masterfrom
ilya-bobyr wants to merge 1 commit intoNixOS:masterfrom
Conversation
It seems reasonable to check if both `.nix-profile` and `.local/state/nix/profile` are present when `$NIX_STATE_HOME` is set. Even more so, `$XDG_STATE_HOME` is used in the `$NIX_LINK_NEW` logic, that was effectively disabled in `nix-profile.fish`. Note that `.local/state/nix/profile` is actually an incorrect path, it will be fixed in a subsequent commit.
ilya-bobyr
force-pushed
the
pr/nix-fish-NIX_STATE_HOME-check-new-profile-location
branch
from
807145c to
e8950c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It seems reasonable to check if both
.nix-profileand.local/state/nix/profileare present when$NIX_STATE_HOMEis set.Even more so,
$XDG_STATE_HOMEis used in the$NIX_LINK_NEWlogic, that was effectively disabled innix-profile.fish.Note that
.local/state/nix/profileis actually an incorrect path, it will be fixed in a subsequent commit.Context
This is a follow-up for changes in #13245.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.