Skip to content

nix-profile{,-daemon}.fish: check for profile in XDG_DATA_HOME#13245

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
stefanboca:sb/push-yoorqzwsxmzn
May 25, 2025
Merged

nix-profile{,-daemon}.fish: check for profile in XDG_DATA_HOME#13245
Mic92 merged 1 commit intoNixOS:masterfrom
stefanboca:sb/push-yoorqzwsxmzn

Conversation

@stefanboca
Copy link
Contributor

Motivation

...and also NIX_STATE_HOME in nix-profile.fish. This is directly translated from the bash scripts and makes the fish scripts equivalent in functionality to the bash scripts.

Context

Note that nix-profile.fish checks for NIX_STATE_HOME and nix-profile-daemon.fish does not, so the two scripts are no longer identical.


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@stefanboca stefanboca requested a review from edolstra as a code owner May 21, 2025 18:32
...and also NIX_STATE_HOME in nix-profile.fish. This is directly
translated from the bash scripts and makes the fish scripts equivalent
in functionality to the bash scripts.

Note that nix-profile.fish checks for NIX_STATE_HOME and
nix-profile-daemon.fish does not, so the two scripts are no longer
identical.
@Mic92 Mic92 enabled auto-merge May 25, 2025 15:16
@Mic92 Mic92 merged commit 247f166 into NixOS:master May 25, 2025
12 checks passed
@roberth roberth added backport 2.28-maintenance Automatically creates a PR against the branch backport 2.29-maintenance Automatically creates a PR against the branch backports created Does not require attention and can be filtered away labels Jul 30, 2025
mergify bot added a commit that referenced this pull request Jul 30, 2025
…3245

nix-profile{,-daemon}.fish: check for profile in XDG_DATA_HOME (backport #13245)
mergify bot added a commit that referenced this pull request Jul 31, 2025
…3245

nix-profile{,-daemon}.fish: check for profile in XDG_DATA_HOME (backport #13245)
@ilya-bobyr
Copy link
Contributor

Note that nix-profile.fish checks for NIX_STATE_HOME and nix-profile-daemon.fish does not, so the two scripts are no longer identical.

What is the reason for this discrepancy?
I think it would be nice to have a comment in the script explaining why are they not identical, if there is a good reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.28-maintenance Automatically creates a PR against the branch backport 2.29-maintenance Automatically creates a PR against the branch backports created Does not require attention and can be filtered away

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants