Skip to content

Fix issue #13018, sourceInfo strict in outputs (backport #13026)#13029

Merged
edolstra merged 3 commits into2.28-maintenancefrom
mergify/bp/2.28-maintenance/pr-13026
Apr 15, 2025
Merged

Fix issue #13018, sourceInfo strict in outputs (backport #13026)#13029
edolstra merged 3 commits into2.28-maintenancefrom
mergify/bp/2.28-maintenance/pr-13026

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Apr 15, 2025

Motivation

Fixes a subtle regression problem, which applies to path inputs only, which were unusable before #10089

Context

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

This is an automatic backport of pull request #13026 done by [Mergify](https://mergify.com).

roberth added 3 commits April 15, 2025 11:52
@roberth @mergify
call-flake.nix: refactor: Bring mapAttrs into scope
9a969e2 
(cherry picked from commit 674375b)
@roberth @mergify
call-flake.nix: allNodes.${key} -> allNodes.${key}.result
6713647 
(cherry picked from commit 9de9410)
@roberth @mergify
fix: Evaluate flake parent source without evaluating its outputs
818fc68 
This requires that we refer to the `sourceInfo` instead of the
`result`. However, `sourceInfo` does not create a chain of basedir
resolution, so we add that back with `flakeDir`.

(cherry picked from commit 2109a5a)
@mergify mergify bot requested a review from edolstra as a code owner April 15, 2025 11:53
@mergify mergify bot added automatic backport This PR is a backport produced by automation (does not trigger backporting) merge-queue labels Apr 15, 2025
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Apr 15, 2025
@edolstra edolstra enabled auto-merge April 15, 2025 12:07
@edolstra edolstra merged commit 5ecbf6b into 2.28-maintenance Apr 15, 2025
25 checks passed
@edolstra edolstra deleted the mergify/bp/2.28-maintenance/pr-13026 branch April 15, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edolstra edolstra Awaiting requested review from edolstra edolstra is a code owner

Assignees

No one assigned

Labels

automatic backport This PR is a backport produced by automation (does not trigger backporting) merge-queue with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@edolstra @roberth