Fix issue #13018, sourceInfo strict in outputs#13026
Merged
Mic92 merged 3 commits intoNixOS:masterfrom Apr 15, 2025
Merged
Conversation
github-actions
bot
added
the
with-tests
Member
|
@zimbatm is this the issue you had? |
This requires that we refer to the `sourceInfo` instead of the `result`. However, `sourceInfo` does not create a chain of basedir resolution, so we add that back with `flakeDir`.
Mic92
added
the
backport 2.28-maintenance
Member
Author
|
Fwiw I don't think the input parent relation has to align with directory parent relation for this problem to occur, i.e. the flakes in the test case could switch locations and the behavior would be the same. |
This was referenced May 12, 2025
MattSturgeon
pushed a commit
to MattSturgeon/flake-compat
that referenced
this pull request
May 19, 2025
(cherry picked from commit NixOS/nix@674375b) (cherry picked from PR NixOS/nix#13026)
MattSturgeon
pushed a commit
to MattSturgeon/flake-compat
that referenced
this pull request
May 19, 2025
(cherry picked from commit NixOS/nix@9de9410) (cherry picked from PR NixOS/nix#13026)
MattSturgeon
pushed a commit
to MattSturgeon/flake-compat
that referenced
this pull request
May 19, 2025
This requires that we refer to the `sourceInfo` instead of the `result`. However, `sourceInfo` does not create a chain of basedir resolution, so we add that back with `flakeDir`. (cherry picked from commit NixOS/nix@2109a5a) (cherry picked from PR NixOS/nix#13026)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes a subtle
regressionproblem, which applies to path inputs only, which were unusable before #10089Context
outputs#13018Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.