C API: Add libflake-c (backport #11940)#11961
Closed
mergify[bot] wants to merge 6 commits into2.25-maintenancefrom
Closed
C API: Add libflake-c (backport #11940)#11961mergify[bot] wants to merge 6 commits into2.25-maintenancefrom
mergify[bot] wants to merge 6 commits into2.25-maintenancefrom
Conversation
(cherry picked from commit 82a23d9)
(cherry picked from commit 1bd7517)
(cherry picked from commit f06f611)
(cherry picked from commit 4eecf3c) # Conflicts: # packaging/everything.nix
[FAIL()] is a macro with `return`, making it unsuitable for helpers. This uses std::runtime_error, because gtest does not seem to provide an exception type of its own for this purpose. [AssertionException] is for a different use case. [FAIL()]: https://google.github.io/googletest/reference/assertions.html#FAIL [AssertionException]: https://github.com/google/googletest/blob/35d0c365609296fa4730d62057c487e3cfa030ff/docs/reference/testing.md#assertionexception-assertionexception (cherry picked from commit d004c52)
(cherry picked from commit 6db6b26)
Contributor
Author
|
Cherry-pick of 4eecf3c has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
github-actions
bot
added
with-tests
Member
|
Closing, see #11949 (comment). Big feature backports should at least have a motivation why this needs a backport and can't wait for the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Nix 2.24's C API is currently incapable of providing flake functionality, because
libflakewasn't wrapped before #9063This PR provides a very basic
libflakethat restoresbuiltins.getFlake. (a feature compensating for a regression)Context
getFlakenot available through C API #11399libnixflake#9063Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.
This is an automatic backport of pull request #11940 done by [Mergify](https://mergify.com).