Merged
Conversation
roberth
added
feature
roberth
force-pushed
the
c-api-libflake
branch
2 times, most recently
from
56a66f6 to
bdf0c8b
Compare
Mic92
reviewed
Nov 24, 2024
github-actions
bot
added
the
with-tests
Ericson2314
reviewed
Nov 24, 2024
Ericson2314
approved these changes
Nov 24, 2024
[FAIL()] is a macro with `return`, making it unsuitable for helpers. This uses std::runtime_error, because gtest does not seem to provide an exception type of its own for this purpose. [AssertionException] is for a different use case. [FAIL()]: https://google.github.io/googletest/reference/assertions.html#FAIL [AssertionException]: https://github.com/google/googletest/blob/35d0c365609296fa4730d62057c487e3cfa030ff/docs/reference/testing.md#assertionexception-assertionexception
roberth
force-pushed
the
c-api-libflake
branch
from
f0e4a81 to
d004c52
Compare
roberth
force-pushed
the
c-api-libflake
branch
from
dff6a64 to
6db6b26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Nix 2.24's C API is currently incapable of providing flake functionality, because
libflakewasn't wrapped before #9063This PR provides a very basic
libflakethat restoresbuiltins.getFlake. (a feature compensating for a regression)Context
getFlakenot available through C API #11399libnixflake#9063Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.