reword documentation on nix-copy-closure#10709
reword documentation on nix-copy-closure#10709fricklerhandwerk merged 5 commits intoNixOS:masterfrom
nix-copy-closure#10709Conversation
- one sentence per line - be more precise with respect to which Nix stores are being accessed - make a clear distinction between store paths and store objects - add links to definitions of terms
fricklerhandwerk
force-pushed
the
reword-nix-copy-closure-docs
branch
from
ca3316f to
130d552
Compare
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
Still doing the counterfactual swing, and have a small suggestion. Otherwise looks good.
|
@roberth thanks for the review, the whole "which machine is which" business really needed clarification. Last round now? |
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
Wish it was the final round, but we're closing in.
|
Ah good, you helped me discover a major error documentation. |
|
End-user, nix novice here. A naive read of the current versions flows quite well for me. I appreciate the changes to clarify how to use this tool! |
roberth
left a comment
roberth
left a comment
There was a problem hiding this comment.
I think the store option should be integrated, but this PR is already an improvement.
| [`--use-substitutes` | `-s`] | ||
| [`-v`] | ||
| _user@machine_ _paths_ | ||
| [_user_@]_machine_[:_port_] _paths_ |
There was a problem hiding this comment.
Fwiw, SSH would call this a "destination" and that would be absolutely awful for us to use.
3 participants
Motivation
Based on discussion with @eflanagan0 and @wamirez.
Related: #10708
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.