Fix curve25519 endianness #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GPG doesn't exactly implement X25519, because it stores ECC scalars in Big-Endian format when the standardised X25519 operates with little endian scalars Therfore we need to reverse the endianness of the private key on key import. This also highlight that the gpg-import test for X25519 was incorrect because the key import failed silently
|
No problem, happy to help! 👍 Very cool to see you working on that and also using Trussed... What a time to be alive! 🥳 Have a nice day! 👋 |
|
is there any way for me to build and test this on my nk3m? :) (instructions mainly) |
robin-nitrokey
approved these changes
Nov 2, 2022
|
@runcom We plan to release a new alpha version probably next week. If you want to give it a try with a virtualized smartcard instead of the hardware, you can install the build dependencies (currently being added in #88) and run the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPG doesn't exactly implement X25519, because it stores ECC scalars in Big-Endian format when the standardised X25519 operates with little endian scalars Therfore we need to reverse the endianness of the private key on key import.
This also highlight that the gpg-import test for X25519 was incorrect because the key import failed silently
Closes #84