Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand command-response tests #81

Merged
merged 14 commits into from
Nov 18, 2022
Merged

Expand command-response tests #81

merged 14 commits into from
Nov 18, 2022

Conversation

sosthene-nitrokey
Copy link
Collaborator

This makes adding future tests easier and adds some test vectors from the gnuk test suite

@sosthene-nitrokey sosthene-nitrokey changed the title Expand command-response tests wip: Expand command-response tests Oct 20, 2022
@sosthene-nitrokey
Copy link
Collaborator Author

So it turns out x25519 key import was incorrect, thanks heiko for noticing it!

x25519 scalar are stored in big endian by gpg, and not in little endian like RFC7718 says.

It also turns out that the gpg tests we had didn't properly test x25519 so we missed it.

@sosthene-nitrokey
Copy link
Collaborator Author

The tests will fail until #89 is fixed

@sosthene-nitrokey sosthene-nitrokey changed the title wip: Expand command-response tests Expand command-response tests Nov 18, 2022
@sosthene-nitrokey sosthene-nitrokey merged commit 0293e62 into main Nov 18, 2022
@sosthene-nitrokey sosthene-nitrokey deleted the command-response branch November 18, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants