Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AES encryption/decryption #64

Merged
merged 9 commits into from
Oct 17, 2022
Merged

Conversation

sosthene-nitrokey
Copy link
Collaborator

@sosthene-nitrokey sosthene-nitrokey commented Oct 4, 2022

This PR is built on top of #60

@sosthene-nitrokey sosthene-nitrokey changed the title WIP: Add support for AES encryption/decryption Add support for AES encryption/decryption Oct 17, 2022
Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

mut ctx: LoadedContext<'_, R, T>,
) -> Result<(), Status> {
if !ctx.state.runtime.other_verified {
warn!("Attempt to ensipher without PW1 verified");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ensipher/encipher/

@sosthene-nitrokey sosthene-nitrokey merged commit ad2d578 into main Oct 17, 2022
@sosthene-nitrokey sosthene-nitrokey deleted the aes-encipher branch October 17, 2022 15:33
@robin-nitrokey robin-nitrokey added this to the v0.2.0 milestone Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants