Manage security environment #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
force-pushed
the
manage-security-environment
branch
from
5d221dc
to
3511da4
Compare
|
I don't understand why the CI fails. It runs on my machine |
|
Ok, it's because of openpgp-card-pcsc which was updated and broke semver. https://gitlab.com/openpgp-card/openpgp-card/-/issues/41 |
|
Upgrading to v0.3 could solve the issue. But v0.3 adds |
sosthene-nitrokey
force-pushed
the
manage-security-environment
branch
from
8265a36
to
3511da4
Compare
sosthene-nitrokey
force-pushed
the
manage-security-environment
branch
2 times, most recently
from
e7e8610
to
25d77d7
Compare
sosthene-nitrokey
changed the title
sosthene-nitrokey
force-pushed
the
manage-security-environment
branch
from
25d77d7
to
5df2046
Compare
robin-nitrokey
approved these changes
Oct 17, 2022
sosthene-nitrokey
force-pushed
the
manage-security-environment
branch
from
5df2046
to
57a1ced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
MANAGE SECURITY ENVIRONMENTcommand.AuthenticationAlgorithmandDecryptionAlgorithmenums ? This would simplify the code and be more flexible, but would allow generation/import of keys that aren't usable.openpgp-cardcrate expose the functionality. I think the easiest way to test it would be to add the functionality toopenpgp-card. See openpgp-card#8