Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use serialization helpers #148

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Use serialization helpers #148

merged 1 commit into from
Apr 24, 2023

Conversation

robin-nitrokey
Copy link
Member

@robin-nitrokey robin-nitrokey commented Apr 23, 2023

Instead of using Trussed’s re-exports of postcard that will be removed in Trussed 0.2.0, we use the public and stable serialization helper methods.

@sosthene-nitrokey
Copy link
Collaborator

Actually we should use trussed_rsa_alloc::RsaPublicParts::(de)serialize rather than postcard directly. Maybe even trussed-rsa-alloc could wrap the RsaPublicParts in a newtype to hide the serde implementation.

@robin-nitrokey
Copy link
Member Author

robin-nitrokey commented Apr 24, 2023

This is already done by this PR (that’s what I meant with “use the public wrapper”). But there is no matching mechanism for the private key injection AFAIS so we have to use postcard there.

@sosthene-nitrokey
Copy link
Collaborator

https://github.com/Nitrokey/trussed-rsa-backend/blob/main/src/types.rs#L79 ?

@robin-nitrokey
Copy link
Member Author

Ah, must have missed that. Updated.

@robin-nitrokey robin-nitrokey changed the title Use postcard directly Use serialization helpers Apr 24, 2023
Instead of using Trussed’s re-exports of postcard that will be removed
in Trussed 0.2.0, we use the public and stable serialization helper
methods.
@sosthene-nitrokey
Copy link
Collaborator

Why didn't the pipeline run?

@robin-nitrokey
Copy link
Member Author

I think it ran (Pipeline #19494) but the checkmarks are missing.

@robin-nitrokey robin-nitrokey merged commit 3a2546e into main Apr 24, 2023
@robin-nitrokey robin-nitrokey deleted the postcard branch April 24, 2023 13:56
@sosthene-nitrokey
Copy link
Collaborator

I triggered it manually

@robin-nitrokey
Copy link
Member Author

Yes, but there’s also a pipeline that was triggered by sync-github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants