Update trussed and dependencies #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-nitrokey
force-pushed
the
update-trussed
branch
7 times, most recently
from
77cde3e
to
e479778
Compare
|
Should we enable RSA-3072 key generation for opcard? |
|
It takes around 20min to generate an RSA3072 key. I'll rerun the test to take accurate timing information, and do it twice (once with the rsa and num-bigint-dig crates optimized with |
daringer
approved these changes
Apr 27, 2023
robin-nitrokey
force-pushed
the
update-trussed
branch
from
e479778
to
88333cc
Compare
|
Key generation takes around 20minutes for RSA3072. I don't think it's worth enabling it. Maybe in a future update it can be configurable through nitropy, so that only users that know about the slowness use it. |
robin-nitrokey
force-pushed
the
update-trussed
branch
from
88333cc
to
c8b7f56
Compare
sosthene-nitrokey
requested changes
Apr 27, 2023
| @@ -387,6 +387,7 @@ impl<R: Runner> App<R> for OpcardApp<R> { | |||
| const BACKENDS_OPCARD: &[BackendId<Backend>] = &[ | |||
| BackendId::Custom(Backend::SoftwareRsa), | |||
| BackendId::Custom(Backend::Auth), | |||
| BackendId::Custom(Backend::Staging), | |||
There was a problem hiding this comment.
You should add it to PIV too.
This patch updates many dependencies, most importantly: - Trussed to v0.1.0-nitrokey.11 - secrets-app to v0.10.0 - opcard to v1.0.0 - piv-authenticator to v0.2.0 - trussed-auth to v0.2.2 It also adds the trussed-staging backend for opcard and piv-authenticator.
robin-nitrokey
force-pushed
the
update-trussed
branch
from
c8b7f56
to
3d6f0c3
Compare
sosthene-nitrokey
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: