This repository was archived by the owner on Oct 12, 2026. It is now read-only.
Repository navigation
fix(sales): stop interpolating the offer name directly after the article 'the' #94
Closed
Closed
Changes from 2 commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
5061dfd
fix(sales): stop interpolating the offer name directly after the arti…
nish3451 5ee9e89
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 2b8db35
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 9e6b262
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 509c2ed
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 217a5fa
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 7003f02
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 addbe53
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 d31a2f2
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 76e25c9
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 16fa003
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 88adbfc
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 edf4f95
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 5174d03
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 2236d19
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 a876428
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 a101c0b
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 95d28d2
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 d559788
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 dfe9bc3
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 5f471e5
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 ba4a8b0
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 a1a0e38
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 647ac38
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 9d9c38e
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 ced6248
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 a31b0bf
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 296016f
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 2558869
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 56e8db7
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 e691782
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 2f5c391
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 9025776
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 b93cc7e
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 2a96604
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 ad7a01f
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 bb145cb
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 bc85c49
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 57f7d41
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 ea00ba3
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 99fb388
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 07673d7
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 97034bd
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 532fd62
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 23bcb6c
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 412e125
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 8823500
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 b39cec2
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 6febf4c
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 62a345d
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 ce15dd9
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 6ec7872
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 5c0c738
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 ad519e1
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 eb92344
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 447ad1e
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 28b40cb
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 e42321a
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 b457a4b
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 9057d12
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 d05093d
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 d6fed74
Merge branch 'main' into fix/operator-copy-offer-article
nish3451 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -249,6 +249,21 @@ for (const path of activeGeneratorSources) { | |
| } | ||
| } | ||
|
|
||
| for (const path of [ | ||
| "scripts/draft-sales-call-prep.mjs", | ||
| "scripts/draft-recording-sharpness-brief.mjs", | ||
| "scripts/draft-loom-recording-script.mjs", | ||
| "scripts/draft-client-kickoff.mjs", | ||
| "scripts/draft-prospect-message.mjs", | ||
| "scripts/lib/canonical-service-copy.mjs", | ||
| "scripts/lib/client-scaffold.mjs" | ||
| ]) { | ||
| const content = existsSync(path) ? readFileSync(path, "utf8") : "" | ||
| if (/\b(?:the|The)\s*\$\{(?:config|FOUNDER_PILOT|day0)\.offerName\}/.test(content)) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The guard only matches when Useful? React with 👍 / 👎. |
||
| failures.push(`${path}: offer name is interpolated directly after the article 'the'`) | ||
| } | ||
| } | ||
|
|
||
| for (const [path, requiredPatterns] of [ | ||
| [ | ||
| "scripts/draft-sales-call-prep.mjs", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hard-coded subset leaves active offer-copy generators such as
create-prospect-audit.mjs,prepare-prospect-close-package.mjs, andexport-proof-library.mjsunchecked, even though they are already listed inactiveGeneratorSourcesand interpolateofferName. If any of those emitsthe ${config.offerName}, the product-truth gate still passes while producing the same "the The Website Correction" regression this guard is intended to prevent; apply the check acrossactiveGeneratorSources(plus any relevant libraries) instead.Useful? React with 👍 / 👎.