-
Notifications
You must be signed in to change notification settings - Fork 0
fix(sales): stop interpolating the offer name directly after the article 'the' #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5061dfd
5ee9e89
2b8db35
9e6b262
509c2ed
217a5fa
7003f02
addbe53
d31a2f2
76e25c9
16fa003
88adbfc
edf4f95
5174d03
2236d19
a876428
a101c0b
95d28d2
d559788
dfe9bc3
5f471e5
ba4a8b0
a1a0e38
647ac38
9d9c38e
ced6248
a31b0bf
296016f
2558869
56e8db7
e691782
2f5c391
9025776
b93cc7e
2a96604
ad7a01f
bb145cb
bc85c49
57f7d41
ea00ba3
99fb388
07673d7
97034bd
532fd62
23bcb6c
412e125
8823500
b39cec2
6febf4c
62a345d
ce15dd9
6ec7872
5c0c738
ad519e1
eb92344
447ad1e
28b40cb
e42321a
b457a4b
9057d12
d05093d
d6fed74
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -249,6 +249,21 @@ for (const path of activeGeneratorSources) { | |
| } | ||
| } | ||
|
|
||
| for (const path of [ | ||
| "scripts/draft-sales-call-prep.mjs", | ||
| "scripts/draft-recording-sharpness-brief.mjs", | ||
| "scripts/draft-loom-recording-script.mjs", | ||
| "scripts/draft-client-kickoff.mjs", | ||
| "scripts/draft-prospect-message.mjs", | ||
| "scripts/lib/canonical-service-copy.mjs", | ||
| "scripts/lib/client-scaffold.mjs" | ||
| ]) { | ||
| const content = existsSync(path) ? readFileSync(path, "utf8") : "" | ||
| if (/\b(?:the|The)\s*\$\{(?:config|FOUNDER_PILOT|day0)\.offerName\}/.test(content)) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The guard only matches when Useful? React with 👍 / 👎. |
||
| failures.push(`${path}: offer name is interpolated directly after the article 'the'`) | ||
| } | ||
| } | ||
|
|
||
| for (const [path, requiredPatterns] of [ | ||
| [ | ||
| "scripts/draft-sales-call-prep.mjs", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hard-coded subset leaves active offer-copy generators such as
create-prospect-audit.mjs,prepare-prospect-close-package.mjs, andexport-proof-library.mjsunchecked, even though they are already listed inactiveGeneratorSourcesand interpolateofferName. If any of those emitsthe ${config.offerName}, the product-truth gate still passes while producing the same "the The Website Correction" regression this guard is intended to prevent; apply the check acrossactiveGeneratorSources(plus any relevant libraries) instead.Useful? React with 👍 / 👎.