fix(public): list all 12 public pages in llms.txt - #68
Conversation
The generated llms.txt only listed 7 of the 12 public URLs, omitting the per-app support/privacy trust pages (promptly/support, promptly/privacy, drishti/support, drishti/privacy) and privacy-choices. Add the missing URLs to the template in prepare-static-site-bundle.mjs and the committed artifact, plus a generator guard that fails the build if llms.txt ever stops covering every public page.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Warning Review limit reached
Next review available in: 37 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32a4b0aa43
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const publicFiles = htmlFiles.filter((relativeFile) => relativeFile !== "404.html"); | ||
| const missing = publicFiles | ||
| .map(pageUrlFor) | ||
| .filter((url) => !content.includes(url)); |
There was a problem hiding this comment.
Require exact URL entries in the coverage guard
When the Home, Promptly, or Drishti landing-page line is removed from llms.txt, this substring check still succeeds because https://tinystudio.in/ appears in every child URL and each product URL appears in its support/privacy URLs. The generator therefore exits successfully while omitting one of those public pages, so the new guard does not reliably prevent the regression it is intended to catch; parse the listed URLs or compare complete lines instead.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a52a3115f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await fs.writeFile(cssPath, css); | ||
| await fs.copyFile(iconPath, appleIconPath); | ||
| await fs.writeFile(path.join(root, "llms.txt"), llmsTxt); | ||
| assertLlmsTxtCoversPublicPages(llmsTxt); |
There was a problem hiding this comment.
Run the coverage assertion in CI
When a future PR removes an entry from the template or edits the committed public/llms.txt without explicitly running npm run site:prepare, this assertion never executes: the checked .github/workflows/codex-ci.yml runs npm run ci, whose only handling of this script is node --check. Consequently all repository checks can pass with incomplete or stale coverage, contrary to the intended regression guard. Add a non-mutating coverage test to npm run ci, or run generation there and fail when it leaves a diff.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e784bb576
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| function assertLlmsTxtCoversPublicPages(content) { | ||
| const publicFiles = htmlFiles.filter((relativeFile) => relativeFile !== "404.html"); |
There was a problem hiding this comment.
Derive coverage from the actual public page set
When a new public/**/index.html page is added and deployed but is accidentally omitted from the manually maintained htmlFiles array, this assertion never considers its URL and still passes while llms.txt remains incomplete. Since the repository already has a recursive public-page enumeration pattern and sitemap.xml is the stated source being matched, build the expected URL set from one of those sources rather than from the same hand-maintained list used by this generator.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Problem
Live llms.txt (public/llms.txt) listed only 7 of the 12 public URLs. The 5 missing URLs were the per-app support/privacy trust pages and privacy-choices:
These pages exist and are already in sitemap.xml, so AI crawlers reading llms.txt were missing the trust pages.
Fix
Verification