fix(public): serve a real 404 page so unknown URLs stop returning the homepage - #34
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Warning Review limit reached
Next review available in: 19 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Comment |
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
… leave the June-20 bundle (#81) * fix(public): add the tinystudio.in release lane (Cloudflare Pages deploy path repair) The live site has served the 2026-06-20 bundle (07acd07) since June 20 while 17+ public PRs merged to main; the Cloudflare Pages git connection for tiny-studio-3f5 never shows checks/statuses on commits and no deploy workflow or secrets exist in the repo. The fleet Workers token lacks Cloudflare Pages:Edit, so no automation on this box can publish today. Add an in-repo release lane that works the moment a Pages-scoped token is provisioned (documented fail-closed message): - scripts/prepare-public-deploy-bundle.mjs: filtered bundle (public/ minus the snoozed-by-Nish managed-service buyer path from PRs #10/#11; every other merged fix preserved), fail-closed in both directions - scripts/test-public-deploy-bundle.mjs: regression guard, wired into npm test/ci (62 checks) - scripts/publish-public-site.mjs: prepare -> wrangler pages deploy to tiny-studio-3f5 -> live verification - scripts/check-public-live-deploy.mjs: live proof for the deploy-path accept (H2-after-H1 /promptly/support/ #18/#20, JSON-LD /contact/ #19, real 404s #34, homepage portfolio-only #29 + no buyer path) - .github/workflows/deploy-public-site.yml: vps-verify lane on push to main - wrangler 4.120.0 devDependency verify: npm test (603 checks, 0 failures); node scripts/prepare-public-deploy-bundle.mjs; git diff --check * fix(public): attach the source commit to Cloudflare Pages deployments wrangler pages deploy accepts --commit-hash/--commit-message/--commit-dirty for dashboard provenance. The bundle already records source_commit in deploy-manifest.json; pass it through so the Pages dashboard links the deployment to the exact tinystudio-in commit that produced the bundle. verify: node --check scripts/publish-public-site.mjs; node scripts/test-public-deploy-bundle.mjs (62 checks, 0 failures) Co-authored-by: CommandCodeBot <noreply@commandcode.ai> --------- Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
…se lane (#104) The soft-404 guard chain had one unguarded link: the release lane's deploy-proof set (NEUTRAL_PROOFS) did not assert the top-level 404 page, even though 'real 404s' is one of the four documented live proofs. The top-level public/404.html is what terminates Cloudflare Pages' single-page-application fallback (without it every unknown URL is served as the homepage with HTTP 200 - the soft-404 PR #34 fixed). Adding it to the proof set makes the lane itself fail closed if 404.html is ever lost or regresses into a homepage clone, instead of only being caught by the post-deploy live check after publishing.
…p) (#149) The repo already carries the real 404 fix (PR #34) and its static guards; the live site serves the 2026-06-20 bundle because the release lane fails closed on the missing CLOUDFLARE_API_TOKEN Pages secret. Document the evidence and the one-time provisioning action that resolves the item. Co-authored-by: nish3451 <nish@tinystudio.in> Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
…live blocked on missing Cloudflare token (#189)
1 participant
What
Adds a top-level
public/404.htmlso unknown URLs on tinystudio.in stop soft-404ing as the homepage.Root cause
Verified live:
https://tinystudio.in/this-url-does-not-exist-xyzreturns HTTP 200 with the full homepage. The site is served by Cloudflare Pages, and per Cloudflare's serving docs:The project had no
404.html, so Pages was in implicit SPA fallback mode: every unmatched route servedindex.htmlwith status 200. Adding a top-level404.htmlswitches Pages to its not-found behavior — unmatched routes now return HTTP 404 with the custom page.Changes
public/404.html(new): a real "Page not found" page styled with the site's shared header/footer and hero-card pattern. One H1,noindexmeta as a belt-and-suspenders guard, canonical omitted, and escape links to real destinations (home, support, contact, Promptly, Drishti). All links resolve to existing pages and follow the repo's WCAG 2.2 tap-target and heading conventions.scripts/prepare-static-site-bundle.mjs:404.htmladded to the preparedhtmlFileslist so it gets the same local-asset normalization and asset assertions as every other page.scripts/test-public-soft-404.mjs(new): regression test asserting the 404 page exists, is not a homepage clone (title/canonical/H1/noindex), all internal links resolve, and it keeps the shared header/footer chrome. Wired intonpm run ciandnpm test.scripts/test-public-link-targets.mjs:404.htmladded to the pages that carry the shared header/footer.Verification
npm run cipasses (exit 0, 0 failures) — includes the new soft-404 test (19 checks).node --checkon all modified scripts;site:prepareis idempotent on the new page (no unintended diffs).200 + homepageto404 + custom pagefor unknown URLs (e.g.https://tinystudio.in/this-url-does-not-exist-xyz).Notes
No dashboard/host configuration changes are required — Cloudflare Pages honors a top-level
404.htmlautomatically. No sitemap, robots, or llms.txt changes: the 404 page is a system page and must not be listed.