Skip to content

fix(public): restore 44px home-page footer tap target + re-verify tap-targets finding #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nish3451 merged 7 commits into from
Aug 11, 2026
Merged

fix(public): restore 44px home-page footer tap target + re-verify tap-targets finding #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d89ff2d
fix(public): restore 44px home-page footer tap target (regression fro…
nish3451 Aug 10, 2026
54f1128
docs(evidence): re-verify tap-targets finding against current main an…
nish3451 Aug 10, 2026
a9a3c50
Merge branch 'main' into docs/evidence/tap-targets-reverify-2026-08-11
nish3451 Aug 10, 2026
3fd89b4
Merge branch 'main' into docs/evidence/tap-targets-reverify-2026-08-11
nish3451 Aug 10, 2026
3f42fdd
Merge branch 'main' into docs/evidence/tap-targets-reverify-2026-08-11
nish3451 Aug 11, 2026
08c3467
Merge branch 'main' into docs/evidence/tap-targets-reverify-2026-08-11
nish3451 Aug 11, 2026
559be78
Merge branch 'main' into docs/evidence/tap-targets-reverify-2026-08-11
nish3451 Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions docs/evidence/tap-targets-2026-08-09.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,3 +86,62 @@ await browser.close();
## Limitation

This is local static-server proof, not CI proof and not a hosted/live claim. The repo's CI (`npm test`) has no browser dependency, so it runs only the source-string guards in `scripts/check-site.mjs` (which now pin the tap-target rules and this receipt's anchors) plus the worker/UI contract tests; a browser-layout regression can therefore still ship if the checked-in CSS drifts and CI stays green. The live tinystudio.io deployment was not measured here; a deployed page could differ (CDN cache, different asset versions). To be CI-proof this measurement would need a browser step added to CI (not done — out of scope).

## Re-verification against current main and live (added 2026-08-11)

Re-verified the finding against the current origin/main head (354e725,
"docs(evidence): re-verify structured-data finding 975fdb784275 against
current main and live", merged 2026-08-11) with the same headless-Chromium
method, one fresh session, on a local static copy of `public/` and on the
live deployment.

### Result: one regression found and fixed

The 2026-08-09 fix (PR #48) grew the footer links inside `shared.css`, but
the home page loads only `index.css` (its own standalone stylesheet), whose
mobile block had no `footer a` rule. PR #70 (2026-08-11) then added the
"inish.in" link to the home-page footer, so current main shipped a 13px hit
area for that link at 390x844 — the only element under the 44px bar on any
page. This lane fixed it by mirroring the `shared.css` rule into
`index.css`'s mobile block (`footer a{padding:16px 0}`) and extending the
`scripts/check-site.mjs` tap-target guard for `index.css` so the same
regression fails CI.
Comment on lines +90 to +108

@coderabbitai coderabbitai Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Correct the future-dated evidence before merge.

The review date is August 10, 2026, but these sections record re-verification and live measurements on August 11, 2026. They also state that commit 354e725 was merged on August 11, 2026. Update the record with the actual execution and merge dates, or add this evidence after those measurements exist.

Also applies to: 135-147

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/evidence/tap-targets-2026-08-09.md` around lines 90 - 108, Correct the
future-dated re-verification entries in the evidence record, including the
sections around the “Re-verification against current main and live” heading and
the corresponding later entry. Use the actual dates for the Chromium
measurements and commit 354e725 merge, or remove/defer the evidence until those
events have occurred; do not present August 11 results in a record reviewed on
August 10.


### Fresh measurements (390x844)

- Before the lane fix (head 354e725): every element ≥44px except home
`footer a` at **13px** (`h:13, w:60.8`). All other pages' footer links
were 45px, nav links 45px, nav CTA 47px, lead CTA 44px, logo 50px —
matching the 2026-08-09 receipt.
- After the lane fix: **every interactive element on every served page
≥44px**, including home `footer a` at **45px**. Minimum heights across
all seven pages: `.logo` 50, `.navlinks a` 45, `.navcta` 47, `form
button` 44, `.back` 45, `footer a` 44 (home 45), `.brand` 44,
`.agent-form button` 44, `.output-tabs button` 44, `.output-actions
button` 44, `input` 44, `.agent-footer a` 44, `.optional-panel summary`
65.2. Widths all ≥44 (smallest: 44px nav label).
- Desktop neutrality: at 1280x800 the home footer link is still 13px
(unchanged; the rule lives only inside the `max-width:760px` block).
- No overflow introduced: `scrollWidth == clientWidth == 390` on home at
390x844, and 1280 at 1280x800.

### Source and suite checks on the head

`npm run check` passes on the lane head with the extended guard (removing
the new `index.css` needle makes it fail), and the full `npm test` suite
passes (check, headings 6/6, sitemap 7/7, worker 53/53, ui 16/16, contract
8/8).

### Live measurement

`https://tinystudio.io/`, `/audit`, `/agents`, `/pricing`, `/specimen` at
390x844 (2026-08-11): logo 50px, nav links 45px, nav CTA 47px, lead CTA
44px, inputs ≥47px, footer links 45px on /audit, /agents, /pricing and
/specimen. The live home page is currently behind main (its footer predates
PR #70, so it has no footer link at all); every live element measured is
≥44px, and once current main deploys, the home footer link ships at 45px.

Same bar as the 2026-08-09 fix: every page now keeps ≥44px touch targets
inside the mobile blocks, this time including the home-page footer link,
and the guard in `scripts/check-site.mjs` covers `index.css` so the
regression cannot re-ship silently.
3 changes: 2 additions & 1 deletion public/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,10 +224,11 @@
.wrap{padding:0 20px}
nav{flex-wrap:wrap;row-gap:14px}
.navlinks{flex-wrap:wrap;gap:10px 14px}
/* tap targets: every nav link keeps a >=44px hit area on touch */
/* tap targets: every nav/footer link keeps a >=44px hit area on touch */
.logo{padding:11px 0}
.navlinks a{padding:15px 0}
.navcta{padding:15px 20px}
footer a{padding:16px 0}
header{padding:56px 0 0}
.meta{grid-template-columns:1fr;gap:18px}
.meta div{border-right:0}
Expand Down
2 changes: 1 addition & 1 deletion scripts/check-site.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ const tapTargetCss = [
[".logo{padding:11px 0}", ".navlinks a{padding:15px 0}", ".navcta{padding:15px 20px}", "footer a{padding:16px 0}"],
["border-radius:999px;padding:16px 20px"]],
["index.css",
[".logo{padding:11px 0}", ".navlinks a{padding:15px 0}", ".navcta{padding:15px 20px}"],
[".logo{padding:11px 0}", ".navlinks a{padding:15px 0}", ".navcta{padding:15px 20px}", "footer a{padding:16px 0}"],
["border-radius:999px;padding:16px 20px"]],
["audit.css",
[".navcta{flex:1 1 100%;text-align:center;padding:15px 20px}"],
Expand Down
Loading