fix(public): restore 44px home-page footer tap target + re-verify tap-targets finding by nish3451 · Pull Request #86 · Nishfleet/TinyStudio.io

nish3451 · 2026-08-10T22:06:48Z

Summary

Round-5 re-verification of the mobile tap targets finding against current main and live.

Finding (re-confirmed): Mobile tap targets fall under WCAG sizes on every page — primary CTAs 42px tall, nav links under 44px. The 2026-08-09 fix (PR #48) was merged, but a regression shipped after it.

Regression found and fixed

PR #70 (2026-08-11) added the inish.in link to the home-page footer — and index.html loads only index.css (not shared.css, where the 2026-08-09 fix put the footer a rule). Result: a 13px hit area at 390x844 on current main.

public/index.css: added footer a{padding:16px 0} to the mobile block, mirroring shared.css.
scripts/check-site.mjs: extended the tap-target guard for index.css so CI catches this regression.

Verification

Fresh headless-Chromium measurement (390x844) of every served page: all elements ≥44px, home footer link now 45px; every other element matched the 2026-08-09 receipt.
Desktop untouched (footer link still 13px at 1280px — rule is inside the max-width:760px block); no horizontal overflow (scrollWidth == clientWidth at 390 and 1280).
npm run check passes (guard fails if the new needle is removed); full npm test suite passes (check + 6 headings + 7 sitemap + 53 worker + 16 ui + 8 contract).
Live measurement 2026-08-11: all live elements ≥44px; live home is behind main (footer predates fix: link Nish's daily reads from the homepage footer #70), so the fix covers the deployed state when current main ships.
Evidence: docs/evidence/tap-targets-2026-08-09.md now records the re-verification with the unfixed 13px measurement, the fixed measurements, and the live checks.

Summary by CodeRabbit

Bug Fixes
- Improved mobile footer link touch areas to meet the recommended 44px minimum.
- Verified interactive elements on the homepage and live deployment meet tap-target requirements.
- Confirmed there is no related mobile layout overflow.
Tests
- Expanded automated checks to help prevent future tap-target regressions.
- Added updated verification documentation covering local and live measurements.

…#70) The 2026-08-09 tap-targets fix (PR #48) grew footer links inside shared.css, but the home page loads only index.css, whose mobile block lacked the footer rule. PR #70 (2026-08-11) then added the 'inish.in' footer link to the home page, shipping a 13px hit area at 390x844. Mirror the shared.css rule into index.css's mobile block and extend the check-site.mjs tap-target guard for index.css so CI catches it. Desktop footer (13px at 1280px) is untouched.

…d live Round-5 re-verification of the mobile tap-targets finding. The 2026-08-09 fix (PR #48) held everywhere except one new element: PR #70 added the 'inish.in' link to the home-page footer, and index.css (the home page's standalone stylesheet) never received the shared.css footer rule — a 13px hit area at 390x844. Fixed and guarded in the previous commit; this receipt records the unfixed 13px measurement, the fixed 45px measurement for every page (all elements >=44px), desktop neutrality, the passing source guards and full suite, and the live measurements (deployment currently behind main, all live elements >=44px).

chatgpt-codex-connector · 2026-08-10T22:06:52Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

coderabbitai · 2026-08-10T22:07:00Z

📝 Walkthrough

Walkthrough

The change adds mobile padding to home-page footer links, extends the source guard to require that rule, and records local and live measurements confirming 44px tap targets without horizontal overflow.

Changes

Footer tap-target correction

Layer / File(s)	Summary
Add and guard footer-link padding `public/index.css`, `scripts/check-site.mjs`	Mobile footer links now use `padding:16px 0`. The site check requires this rule.
Record local and live verification `docs/evidence/tap-targets-2026-08-09.md`	The evidence record documents the regression, passing measurements, source checks, test results, and live deployment verification.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

nish3451/TinyStudio.io#8: Introduced the tap-target rules extended by this change.
nish3451/TinyStudio.io#48: Added earlier mobile tap-target styling extended here for footer links.
nish3451/tinystudio-in#22: Also updates footer-link CSS and CI validation for tap targets.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the footer tap-target fix and the related re-verification documented in the pull request.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch docs/evidence/tap-targets-reverify-2026-08-11

_{Comment @coderabbitai help to get the list of available commands.}

greptile-apps

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

greptile-apps

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/evidence/tap-targets-2026-08-09.md`:
- Around line 90-108: Correct the future-dated re-verification entries in the
evidence record, including the sections around the “Re-verification against
current main and live” heading and the corresponding later entry. Use the actual
dates for the Chromium measurements and commit 354e725 merge, or remove/defer
the evidence until those events have occurred; do not present August 11 results
in a record reviewed on August 10.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 10a14428-7f4e-4e0f-8f91-a3d11c5f753b

📥 Commits

Reviewing files that changed from the base of the PR and between d70bea0 and a9a3c50.

📒 Files selected for processing (3)

docs/evidence/tap-targets-2026-08-09.md
public/index.css
scripts/check-site.mjs

coderabbitai · 2026-08-10T22:44:19Z

+## Re-verification against current main and live (added 2026-08-11)
+
+Re-verified the finding against the current origin/main head (354e725,
+"docs(evidence): re-verify structured-data finding 975fdb784275 against
+current main and live", merged 2026-08-11) with the same headless-Chromium
+method, one fresh session, on a local static copy of `public/` and on the
+live deployment.
+
+### Result: one regression found and fixed
+
+The 2026-08-09 fix (PR #48) grew the footer links inside `shared.css`, but
+the home page loads only `index.css` (its own standalone stylesheet), whose
+mobile block had no `footer a` rule. PR #70 (2026-08-11) then added the
+"inish.in" link to the home-page footer, so current main shipped a 13px hit
+area for that link at 390x844 — the only element under the 44px bar on any
+page. This lane fixed it by mirroring the `shared.css` rule into
+`index.css`'s mobile block (`footer a{padding:16px 0}`) and extending the
+`scripts/check-site.mjs` tap-target guard for `index.css` so the same
+regression fails CI.


📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Correct the future-dated evidence before merge.

The review date is August 10, 2026, but these sections record re-verification and live measurements on August 11, 2026. They also state that commit 354e725 was merged on August 11, 2026. Update the record with the actual execution and merge dates, or add this evidence after those measurements exist.

Also applies to: 135-147

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/evidence/tap-targets-2026-08-09.md` around lines 90 - 108, Correct the future-dated re-verification entries in the evidence record, including the sections around the “Re-verification against current main and live” heading and the corresponding later entry. Use the actual dates for the Chromium measurements and commit 354e725 merge, or remove/defer the evidence until those events have occurred; do not present August 11 results in a record reviewed on August 10.

greptile-apps

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

greptile-apps

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

greptile-apps

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

greptile-apps

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

nish3451 added 2 commits August 11, 2026 03:36

greptile-apps Bot reviewed Aug 10, 2026

View reviewed changes

Merge branch 'main' into docs/evidence/tap-targets-reverify-2026-08-11

a9a3c50

greptile-apps Bot reviewed Aug 10, 2026

View reviewed changes

coderabbitai Bot reviewed Aug 10, 2026

View reviewed changes

Merge branch 'main' into docs/evidence/tap-targets-reverify-2026-08-11

3fd89b4

greptile-apps Bot reviewed Aug 10, 2026

View reviewed changes

Merge branch 'main' into docs/evidence/tap-targets-reverify-2026-08-11

3f42fdd

greptile-apps Bot reviewed Aug 11, 2026

View reviewed changes

Merge branch 'main' into docs/evidence/tap-targets-reverify-2026-08-11

08c3467

greptile-apps Bot reviewed Aug 11, 2026

View reviewed changes

Merge branch 'main' into docs/evidence/tap-targets-reverify-2026-08-11

559be78

greptile-apps Bot reviewed Aug 11, 2026

View reviewed changes

nish3451 merged commit 0ad7481 into main Aug 11, 2026
3 checks passed

nish3451 mentioned this pull request Aug 11, 2026

docs(evidence): re-verify tap-targets finding — closed on current main and live #133

Merged

Navigation Menu

Uh oh!

fix(public): restore 44px home-page footer tap target + re-verify tap-targets finding - #86

fix(public): restore 44px home-page footer tap target + re-verify tap-targets finding#86
nish3451 merged 7 commits into
mainfrom
docs/evidence/tap-targets-reverify-2026-08-11

nish3451 commented Aug 10, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

chatgpt-codex-connector Bot commented Aug 10, 2026

Uh oh!

coderabbitai Bot commented Aug 10, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

greptile-apps Bot left a comment

Uh oh!

greptile-apps Bot left a comment

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Aug 10, 2026

Uh oh!

greptile-apps Bot left a comment

Uh oh!

greptile-apps Bot left a comment

Uh oh!

greptile-apps Bot left a comment

Uh oh!

greptile-apps Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

nish3451 commented Aug 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Regression found and fixed

Verification

Summary by CodeRabbit

Uh oh!

chatgpt-codex-connector Bot commented Aug 10, 2026

Uh oh!

coderabbitai Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Aug 10, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

nish3451 commented Aug 10, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 10, 2026 •

edited

Loading