Support detecting updates for prerelease mod versions #15212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's say we have mod with current version `1.0.0-pre1` and newest `1.0.0-pre2`. Coercing it would convert them both to 1.0.0 == 1.0.0 and update notification won't occur
To be able to support prereleases
|
FYI we are not ignoring your PR! We just didn't get a chance to test the new semver module yet; the weeks leading up to yesterday's release were quite busy. Will start testing once we confirm that 1.10.X is stable enough. |
|
merged in #15281 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
includePrereleaseoption, that has been added since semver 7.6.0, to parse version with prerelease.Continuation of #15044 after semver PR has been merged
Fixes #15213