Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ 12-colocation 번역 완료 #126

Merged
merged 2 commits into from
Jun 21, 2023
Merged

✨ 12-colocation 번역 완료 #126

merged 2 commits into from
Jun 21, 2023

Conversation

daveg7lee
Copy link
Contributor

@daveg7lee daveg7lee commented Jun 21, 2023 •
edited
Loading

기여자용

문서 개선

Progress

@ChanghyeonYoon ChanghyeonYoon added the documentation 문서 작업 label Jun 21, 2023
@ChanghyeonYoon ChanghyeonYoon linked an issue Jun 21, 2023 that may be closed by this pull request
12-colocation.mdx #23
Closed
@ChanghyeonYoon
Copy link
Member

@daveg7lee 수고하셨습니다! 리뷰 확인 부탁드립니다!

@daveg7lee
Copy link
Contributor Author

아 혹시 리뷰는 어떻게 확인할 수 있을까요?

@ChanghyeonYoon
Copy link
Member

@daveg7lee https://github.com/Nextjs-kr/Nextjs.kr/pull/126/files 참고 하시면 되세요!

@daveg7lee
Copy link
Contributor Author

제가 직접 리뷰하는건가요..?

ChanghyeonYoon
ChanghyeonYoon reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@ChanghyeonYoon ChanghyeonYoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 반영 부탁드립니다 :)

@ChanghyeonYoon
Copy link
Member

@daveg7lee 아 제가 리뷰 제출을 안했네요 ㅠㅠ 다시 확인해보세요!

@daveg7lee
Copy link
Contributor Author

아 확인했습니다! 감사합니다!

@daveg7lee
Copy link
Contributor Author

반영하였습니다!

@ChanghyeonYoon ChanghyeonYoon self-requested a review June 21, 2023 11:23
ChanghyeonYoon
ChanghyeonYoon approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@ChanghyeonYoon ChanghyeonYoon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
추가로 하시고 싶은 티켓이 있다면 신청해주셔도 됩니다!

@daveg7lee
Copy link
Contributor Author

넵 알겠습니다!

@ChanghyeonYoon ChanghyeonYoon merged commit 5539619 into Nextjs-kr:main Jun 21, 2023
@ChanghyeonYoon ChanghyeonYoon mentioned this pull request Jun 21, 2023
Open
@JoChaeWoo JoChaeWoo mentioned this pull request Jun 22, 2023
Merged
7 tasks
This was referenced Jul 10, 2023
Merged
Open
@g2hhh2ee g2hhh2ee mentioned this pull request Jul 14, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChanghyeonYoon ChanghyeonYoon ChanghyeonYoon approved these changes

Assignees

@daveg7lee daveg7lee

Labels
documentation 문서 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

12-colocation.mdx
2 participants
@daveg7lee @ChanghyeonYoon