Repository navigation
A11Y-001: the readiness score reads in the light theme - #998
Merged
Merged
Conversation
The command center's readiness label and ring were coloured with Tailwind's green-500, amber-400 and red-400 as inline hex, picked against the dark theme: 2.2, 1.6 and 2.7:1 on the light theme's card. They take the theme's status roles now (text-/stroke-success, warning, danger), which hold 4.5:1 in both themes, and the ring's track is fg/10 instead of a white that vanished on a white card. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TRY21ZKsFrfB3qtoP972A4
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Oct 10, 2026
NewWorldVenture
marked this pull request as ready for review
October 11, 2026 00:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A11Y-001: one of the light-theme leftovers from the signed-in sweep (#990).
The defect
/dashboard/command-centercolours its readiness label ("On track", "Needs attention", "Action required") and its ring with Tailwind's green-500, amber-400 and red-400, written as inline hex. Those colours were picked against the dark theme. On the light theme's card (bg-surface/40over--bg) the label reads:#22c55e#fbbf24#f87171The ring's track was
rgba(255,255,255,0.08): white, so it disappeared on a white card.The fix
text-andstroke-success,warninganddanger. Those already hold 4.5:1 on every ground in both themes (tests/brand-contrast-contract.test.ts). The class names are written out whole, so Tailwind generates them.stroke-fg/10, which is visible in both themes and nearly what it was in the dark theme.Tests
tests/the-readiness-score-reads-in-the-light-theme.test.tsstyle={{ color }}remains.globals.css, in both themes.mainmaintoo) / 0 / cleanThe page's other English literals ("On track", the issue counts) are an i18n matter and are not changed here.
No migration, configuration or dependency change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TRY21ZKsFrfB3qtoP972A4
Generated by Claude Code