Repository navigation
A11Y-001: the light theme's 500 and 600 palette text is readable - #1000
Merged
Merged
Conversation
#991 gave each hue's text-*-200/300/400 a darker colour in .light. The app also writes the 500 and 600 shades 262 times (text-amber-500 alone 74), often as light-first class strings (text-amber-600 dark:text-amber-400). Held to #991's bar - 4.5:1 on white, --bg and the hue's 500/20 chip tint - every 500 and every 600 but indigo's fails (1.6 to 4.2:1). The block is regenerated with the same shape, targets, exclusions and specificity, adding each failing 500/600 and its hover, group-hover and used slash forms. The unit test computes which shades need a rule, checks a base rule for every base class the source uses, and counts selectors per remapped shade; Kitchen Mode's boundary check now covers its amber-600. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TRY21ZKsFrfB3qtoP972A4
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Oct 10, 2026
NewWorldVenture
marked this pull request as ready for review
October 11, 2026 00:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A11Y-001: extends #991's light-theme palette remap to the 500 and 600 shades.
The defect
#991 gave each hue's
text-<hue>-200/300/400a darker colour in.light. The app also writes the 500 and 600 shades into class names: 262 times in 73 files. The most common aretext-amber-500(74),text-emerald-500(44),text-emerald-600(28),text-amber-600(27) andtext-rose-500(24). Many are light-first class strings (text-amber-600 dark:text-amber-400). Held to #991's bar (4.5:1 on white, on--bgand on the hue's own 500/20 chip tint), every 500 and every 600 but indigo's fails:The fix
The same block, the same rule shape, the same targets. The block is regenerated by the script that reproduces #991's rules byte for byte for 200–400, with 500 and 600 added for every hue where the shade itself fails:
hover:andgroup-hover:forms, and any slash variant the source uses take the hue's existing target (for example emerald-800 or rose-700)..dark, and anything in or under.keep-dark-palettekeep their shades (Kitchen Mode'stext-amber-600stays as it is).md:,dark:) still wins. A hover or group-hover rule carries one more class than the variant it replaces.Dark theme: unchanged.
Tests
tests/light-theme-palette-text-is-readable.test.ts(#991's) is extended rather than duplicated:3 × hues.maintext-amber-500alone; the specificity count)maincolor-contrast, light theme, 246 signed-in routes, 1280 px (author-run, local, production builds ofmaina9b7e87 and this branch, empty household)/display, the axe background-propagation reading described in #991)maintests/e2e/light-theme-palette-in-the-browser.spec.ts(#991's cascade proof: exclusions, hover, slash, Kitchen Mode, the display), against this branch's buildtext-amber-600headingglobals.css/ full unit suite / tscmaintoo) / 0What is left in the light theme (1280 px, this branch)
Six nodes, none of them palette text:
text-accenton its ownbg-accent/15: the sync direction chip and every accentBadge, 3.87:1. The same shape as A11Y-001: a status chip's text is readable on its own tint #994's status roles, withaccentthe one role it left out. Next.text-mutedon thebg-brand/10selection tint: the active conversation row, 4.39:1. Next.opacity-60takes its text to 4.49:1. Next./dashboard/choreshere. At 390 px it appears on seven routes, five through the sharedButtonand two inlinebg-brand … hover:bg-brand/90.hover:bg-brand/90lightens--branduntil white reads 4.18–4.21:1. The sweep's pointer happened to rest on these buttons. The sharedButtonis outside what I touch, so this one is yours to decide (a darker hover, or a slightly darker--brand).No component, configuration or dependency change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TRY21ZKsFrfB3qtoP972A4
Generated by Claude Code