Skip to content

Integrate display accessibility fixes and reconcile production audit evidence - #600

Merged
NewWorldVenture merged 7 commits into
mainfrom
codex/audit-page-integration-20260927
Sep 27, 2026
Merged

NewWorldVenture merged 7 commits into
mainfrom
codex/audit-page-integration-20260927

Conversation

@NewWorldVenture

@NewWorldVenture NewWorldVenture commented Sep 27, 2026 •

Copy link
Copy Markdown
Owner

Integrates the reviewed changes from #596 and #597 onto the deployed media fixes. The kitchen display has one keyboard-reachable scrolling region instead of nested scroll boxes, two text links remain visibly underlined, and seven translation catalogs retain their earlier, more helpful messages instead of duplicate keys overwriting them.

The audit reconciliation preserves all 14,186 existing inventory IDs, all 841 Session A rows, Claude's 44 production surface observations and eight framework findings, and the generated finding index. One new regression-test inventory row brings the total to 14,187. The latest media release's exact production checks and full local gates are recorded; the framework diagnosis is attributed to Claude and is not represented as an independently reproduced load test.

Validation: all 36 focused display/media browser cases pass on the combined source, with 1,355 copied source files checked by SHA-256. Audit tally checks pass. The complete combined local gates pass: 20,752/20,752 unit tests across 1,624 files, the 247-page production build, generated-route strict types, and lint with 15 existing warnings. All 5,195 tracked files and modes were checked before and after against the exact committed tree. This PR's hosted CI remains pending. Incoming #596 hosted checks succeeded, with two automatic browser retries (weekly-meal timeout and a React #418 on /dashboard/sleep); those qualifications remain unresolved and are not represented as a clean first-pass matrix. This includes neither the unreviewed framework upgrade nor the separate #585/#598 changes under correction.

claude and others added 7 commits September 27, 2026 16:46
Lane A (public, auth and marketing pages) re-crawled on production at
e14b12e, phone and desktop, with axe: all 44 rows move to CLEAN, and
the lane is released.

A signed-in 1280 px axe run found three things the phone sweep could
not see, fixed here:
- the family display's list tiles scroll inside a fixed-height cell
  with no keyboard stop: each scrolling tile is now a named, focusable
  region, and the lists inside a tile no longer scroll on their own
  (one scroller per tile, the reachable one);
- /dashboard/calm and the wallet child view each had an empty-state
  link told from its sentence by colour alone: now underlined.

Guard cases in tests/a-signed-in-control-has-a-name.test.ts fail with
the fixes reverted. finalaudit.md gains Q74 (the #548 release and the
#588-#590 live-page fixes) and the findings rows. The live-page auditor
gains --paths and --cookies for targeted and signed-in runs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TRY21ZKsFrfB3qtoP972A4
…he owner's

The 8 pages that stayed open on an intermittent React #418 have a root
cause. A local build with component names kept and React's mismatch throw
instrumented showed the same shape in 7 of 7 hits: React tried to hydrate an
element while its cursor already pointed at that element's own first child.
Late React Server Components chunks make a host element suspend
mid-hydration on a time-sliced render, and replaySuspendedUnitOfWork replays
it without rewinding the hydration cursor: react/react#37584, in the React
19.2 canary that Next 15.5.25 and 15.5.26 bundle. The server HTML is
correct and React recovers, but the error is thrown.

The fix is a decision for the owner (wait for a Next release that bundles
the fixed React, or backport the upstream fix into the build); patching the
framework's React from this session was stopped by the environment's
permission check. The 8 rows move from OPEN to OWNER with that recorded.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KP9rt5rVQ9jDMpZp2xBy3K
Two sessions added actions.couldNotSaveThatPlace, couldNotDeleteThatPlace
and couldNotUpdateThatGeofence independently; the merge kept both in
seven catalogues and JSON.parse keeps the last, so the terse copy won
and a failed geofence switch never said the alert setting had not
changed. The later duplicates are dropped, pt-PT's surviving copy says
geocerca like the rest of pt-PT (it said the Spanish geovalla), and a
guard fails any catalogue that defines a key twice.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TRY21ZKsFrfB3qtoP972A4
…entation-ld8bon

# Conflicts:
#	finalaudit.md
@vercel

vercel Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
bubaly Ignored Ignored Sep 27, 2026 5:09pm UTC

Request Review

@NewWorldVenture
NewWorldVenture marked this pull request as ready for review September 27, 2026 17:17
@NewWorldVenture
NewWorldVenture merged commit a6dcd18 into main Sep 27, 2026
6 of 7 checks passed
NewWorldVenture pushed a commit that referenced this pull request Sep 27, 2026
NewWorldVenture pushed a commit that referenced this pull request Sep 27, 2026
Main moved 46 commits with no new migrations, so 0446–0458 stay put.
111 files conflicted:
- 61 page titles: the port's translated generateMetadata is kept over
  main's brand-stripped static title. The two that end in the brand go
  through titleWithoutDoubledBrand.
- 32 accessible names both sides added: main's page-specific keys are kept,
  so none is left unused.
- The rest combine main's ownChannel (P-03), role="switch" and
  suppressHydrationWarning with the port's translations and its
  stale-refresh guard.
- Three en-US keys the automatic merge dropped are restored, with main's
  wording in all seven catalogues.

tsc clean. Lint: 0 errors, 15 warnings. 21,277 tests in 1,684 files pass
in UTC and in America/Los_Angeles.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DXw2nu25BjyRfA6Fg3YiMS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants