Skip to content

Count seven family calendar dates in the first briefing - #496

Closed
NewWorldVenture wants to merge 3 commits into
codex/strategy-timed-ics-import-20260910from
codex/strategy-first-brief-calendar-week-20260910
Closed

NewWorldVenture wants to merge 3 commits into
codex/strategy-timed-ics-import-20260910from
codex/strategy-first-brief-calendar-week-20260910

Conversation

@NewWorldVenture

Copy link
Copy Markdown
Owner

The first briefing's week count excluded all-day entries and used an elapsed-hour window that could include yesterday, admit extra calendar dates, or miss early events on a 25-hour day. It now counts event starts on seven family calendar dates, today through day +6. All-day events retain their original date and count toward the organized calendar. Only timed events contribute to conflicts, missing-location/recurring opportunities and the existing modeled-minute estimate.

This changes newly generated counts and canonical summaries where the old horizon was wrong; stored summaries are not rewritten. An all-day-only import shows a nonempty organized calendar with zero modeled minutes. The public sample remains exactly 3 today / 1 clash / 3 handled / 44 modeled minutes. Start-date membership remains: multi-day/overnight expansion and Home's separate raw upcoming count are unchanged.

Based on #494 at 14db1ac and includes both #487 prerequisite commits as f02d150 and 9d1fb25. Retain both prerequisites. The new week-only commit is 70c5bf7, three files, with one 24-line production diff; all three blobs match independently reviewed d5d333bd.

Validation: 14 failures and four controls were reproduced before the change; all 18 new cases now pass. Author validation passes 363 tests across seventeen suites, TypeScript, scoped lint, all eight translation gates and diff check. Independent review reran 53 overlapping tests and verified sixteen browser fingerprints. Actual React fixtures pass 56 Value/Done views and 28 Finish journeys across mixed/all-day-only calendars, seven locales and 320/1280 widths, with no errors or overflow. Server/provider boundaries use disclosed adapters. The publishable branch passes 731 tests across 41 relevant suites; combined rehearsal d64e438b passes 110 tests across eight suites. Full-suite/build evidence from earlier checkpoints is not reassigned to this change.

No new catalogue entries, provider actions, session/payload/receipt changes, SQL or shared navigation changes. Keep draft pending checks on the published head.

@vercel

vercel Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
bubaly Ready Ready Preview Sep 10, 2026 12:12pm UTC

Request Review

NewWorldVenture pushed a commit that referenced this pull request Sep 10, 2026
# Conflicts:
#	lib/i18n/messages/de-DE.json
#	lib/i18n/messages/en-US.json
#	lib/i18n/messages/es-ES.json
#	lib/i18n/messages/fr-FR.json
#	lib/i18n/messages/it-IT.json
#	lib/i18n/messages/nl-NL.json
#	lib/i18n/messages/pt-PT.json
#	lib/onboarding/first-brief.ts
#	tests/first-brief-display.test.ts

Copy link
Copy Markdown
Owner Author

Shipped — this landed on main in #500 (merge commit f478dce5).

It stayed open only because its base is codex/strategy-timed-ics-import-20260910, a stacked branch that never moved, so the auto-close-on-merge never applied. Retargeting it to main is refused by GitHub with "There are no new commits between base branch 'main' and head branch 'codex/strategy-first-brief-calendar-week-20260910'" — which is the confirmation that every commit here is already in main.

This was one of the seven that needed a real decision rather than a mechanical merge. week and weekEvents look like a rename but aren't — week is the timed-only subset used for overlap detection, so counting from it would have silently dropped all-day dates. Counting all seven family dates is this PR's entire purpose and the neighbouring lines already used weekEvents, so weekEvents is what the merged code counts.

Closing as redundant, not rejected.


Generated by Claude Code

This branch was successfully deployed

1 active deployment
Preview — 70c5bf7e Deployed Sep 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant