Skip to content

Localize generated onboarding briefs while preserving canonical data - #487

Closed
NewWorldVenture wants to merge 2 commits into
codex/strategy-onboarding-copy-localization-20260910from
codex/strategy-first-brief-display-20260910
Closed

NewWorldVenture wants to merge 2 commits into
codex/strategy-onboarding-copy-localization-20260910from
codex/strategy-first-brief-display-20260910

Conversation

@NewWorldVenture

@NewWorldVenture NewWorldVenture commented Sep 10, 2026 •

Copy link
Copy Markdown
Owner

Generated onboarding brief text remained English after the wizard controls were translated. Value and Done now render a separate localized view in all seven languages, using semantic facts captured where the engine already computes them. Timelines and conflict ranges use the generation timezone; overlap ranges crossing a clock change include both offsets so a positive interval does not appear backward.

Stacked on #484 at 184045ac206803bf524c6a8b55d6e692eb004b15; final head 8ac56c22865d3db16426820624c328e5c91d56b4. Optional strict display descriptors preserve canonical English fields, IDs, counts, order, minutes, raw imported titles/locations, dinner data and byte-equivalent briefSummary output. Legacy or malformed metadata falls back per affected item. The view is never submitted or persisted; no snapshot storage, Home/API/notification consumer, provider or owner boundary is changed. Twenty-six keys per locale are appended without changing any of the 12,752 previous values or their order.

Validation:

  • Original scoped regression runs cover 613 unique checks across twenty files, including briefing/schema, onboarding, privacy and quarantined storage. Final formatter and actual Wizard callback suites pass 65 tests, including spring/fall offset transitions and the newly required locale mock; these counts overlap. Scoped lint, all eight translation gates, typecheck and diff checks pass.
  • Independent review reproduced a missing useLocale test mock and ambiguous fall-back overlap range; both are corrected at this head. No production workaround or weakened business assertions was introduced.
  • Actual controlled Chromium passes 19 scenarios across seven locales at 320/1280, including Value-to-Done, locale switching, legacy/malformed fallback, paste preview and narrow clock-change overlap. All 24 source fingerprints match, with zero browser errors/external requests. Forty-five comparisons against the parent engine preserve every canonical field and summary JSON byte. Finalization payloads, calendar receipts and owner callbacks remain unchanged.
  • The unpublished current-main rehearsal incorporating this branch and the separately reviewed timezone callers passes 11,918 tests across 1,100 suites at 6dedb168. Its later localized preview-error correction at 13c8358e passes 221 targeted tests. These integration results do not replace final-head CI.

Browser evidence uses actual components/styles with controlled loopback transport; live providers, deployed sessions and production storage are not established. Home/API/notification copy and recipient locale remain separate work. Required core, mobile, database, E2E and Vercel checks passed at this exact head in CI run 34469891652. Actual E2E logs record 428 passes and five inherited durable-session skips; the unchanged older session suite is gated by an absent flag, so these runs do not add session acceptance. Ready for review.

@vercel

vercel Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
bubaly Ready Ready Preview Sep 10, 2026 11:12am UTC

Request Review

@NewWorldVenture
NewWorldVenture marked this pull request as ready for review September 10, 2026 11:25
NewWorldVenture pushed a commit that referenced this pull request Sep 10, 2026
# Conflicts:
#	lib/i18n/messages/de-DE.json
#	lib/i18n/messages/en-US.json
#	lib/i18n/messages/es-ES.json
#	lib/i18n/messages/fr-FR.json
#	lib/i18n/messages/it-IT.json
#	lib/i18n/messages/nl-NL.json
#	lib/i18n/messages/pt-PT.json

Copy link
Copy Markdown
Owner Author

Shipped — this landed on main in #500 (merge commit f478dce5).

It stayed open only because its base is codex/strategy-onboarding-copy-localization-20260910, a stacked branch that never moved, so the auto-close-on-merge never applied. Retargeting it to main is refused by GitHub with "There are no new commits between base branch 'main' and head branch 'codex/strategy-first-brief-display-20260910'" — which is the confirmation that every commit here is already in main.

Closing as redundant, not rejected.


Generated by Claude Code

This branch was successfully deployed

1 active deployment
Preview — 8ac56c22 Deployed Sep 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant