Repository navigation
Localize generated onboarding briefs while preserving canonical data - #487
Closed
NewWorldVenture wants to merge 2 commits into
Closed
NewWorldVenture wants to merge 2 commits into
NewWorldVenture wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 10, 2026
NewWorldVenture
marked this pull request as ready for review
September 10, 2026 11:25
This was referenced Sep 10, 2026
NewWorldVenture
pushed a commit
that referenced
this pull request
Sep 10, 2026
# Conflicts: # lib/i18n/messages/de-DE.json # lib/i18n/messages/en-US.json # lib/i18n/messages/es-ES.json # lib/i18n/messages/fr-FR.json # lib/i18n/messages/it-IT.json # lib/i18n/messages/nl-NL.json # lib/i18n/messages/pt-PT.json
Owner
Author
|
Shipped — this landed on It stayed open only because its base is Closing as redundant, not rejected. Generated by Claude Code |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated onboarding brief text remained English after the wizard controls were translated. Value and Done now render a separate localized view in all seven languages, using semantic facts captured where the engine already computes them. Timelines and conflict ranges use the generation timezone; overlap ranges crossing a clock change include both offsets so a positive interval does not appear backward.
Stacked on #484 at
184045ac206803bf524c6a8b55d6e692eb004b15; final head8ac56c22865d3db16426820624c328e5c91d56b4. Optional strict display descriptors preserve canonical English fields, IDs, counts, order, minutes, raw imported titles/locations, dinner data and byte-equivalent briefSummary output. Legacy or malformed metadata falls back per affected item. The view is never submitted or persisted; no snapshot storage, Home/API/notification consumer, provider or owner boundary is changed. Twenty-six keys per locale are appended without changing any of the 12,752 previous values or their order.Validation:
6dedb168. Its later localized preview-error correction at13c8358epasses 221 targeted tests. These integration results do not replace final-head CI.Browser evidence uses actual components/styles with controlled loopback transport; live providers, deployed sessions and production storage are not established. Home/API/notification copy and recipient locale remain separate work. Required core, mobile, database, E2E and Vercel checks passed at this exact head in CI run 34469891652. Actual E2E logs record 428 passes and five inherited durable-session skips; the unchanged older session suite is gated by an absent flag, so these runs do not add session acceptance. Ready for review.