Skip to content

Keep Home calendar dates accurate and failed reads visible - #493

Closed
NewWorldVenture wants to merge 2 commits into
codex/strategy-home-outcome-localization-20260910from
codex/strategy-home-calendar-readers-20260910
Closed

NewWorldVenture wants to merge 2 commits into
codex/strategy-home-outcome-localization-20260910from
codex/strategy-home-calendar-readers-20260910

Conversation

@NewWorldVenture

@NewWorldVenture NewWorldVenture commented Sep 10, 2026 •

Copy link
Copy Markdown
Owner

Home now keeps all-day events on their recorded date and timed events on the family's local day. Calendar queries apply typed date bounds before the existing limits, including DST midnight changes and the complete terminal dates for upcoming/assigned events. Calendar labels follow the viewer's locale and family timezone. Explicit zero-duration entries remain on the schedule without creating a false conflict.

When a required calendar read fails, the affected section shows a translated retry notice. Healthy tasks, reminders, available calendar sections and unrelated insights remain visible. Failed reads suppress dependent clear-day/outcome/conflict claims; successful empty reads and recovery keep their normal behavior. Family/member filters, manager visibility, order/limits, reminder behavior and stored records remain intact.

This branch is based on #491 at 574ed32 and includes the already-reviewed #492 prerequisite (locally 97c7d92). The new Home-only commit is 8557a3a, changing thirteen files; retain both prerequisites during integration.

Validation:

  • Actual async Home reader/SSR tests reproduced nine failures across twelve cases before the fix. Additional point-event cases reproduced false overlaps. All 283 affected tests across seventeen suites pass; independent review reran 105 overlapping tests across eight suites.
  • 56 controlled Chromium views cover seven locales, narrow/wide screens and each failed calendar section, with successful retry-fixture navigation and no page errors, overflow or clipped notices. These use real server-rendered Home/read models/catalogues with local service/widget/database doubles; they do not establish Next hydration or live provider behavior.
  • Actual Supabase-client URL serialization and official PostgREST parser/planner/SQL source confirm both OR filters remain conjunctive. Seeded reader tests preserve family/member exclusion before limits of 5/5/200.
  • TypeScript, scoped lint, all eight translation gates and diff checks pass. Twenty-seven protected files and all prior catalogue values/order are preserved; three notice keys are added per locale.
  • Combined unpublished cccd9fe0d84fcf2589b68adc70fd36dba39067a1 passes 183 tests across nine relevant suites. Earlier full-suite/build evidence belongs to 474379bc; it is not reassigned to this later change.

Upcoming includes day 1 through day 7; assigned conflicts include day 0 through day 14. Existing start-date-only selection remains. No SQL, shared navigation, dependency, provider or snapshot-persistence changes. All five required checks pass on exact head 8557a3a in run 34473121001. E2E job 102857436564 passes 428 cases with the same five gated durable-session skips; workflow and E2E/config files are unchanged from the branch base. Ready for owner review; integration and deployment remain separate.

@vercel

vercel Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
bubaly Ready Ready Preview Sep 10, 2026 11:49am UTC

Request Review

@NewWorldVenture
NewWorldVenture marked this pull request as ready for review September 10, 2026 12:01
NewWorldVenture pushed a commit that referenced this pull request Sep 10, 2026
# Conflicts:
#	lib/i18n/messages/de-DE.json
#	lib/i18n/messages/en-US.json
#	lib/i18n/messages/es-ES.json
#	lib/i18n/messages/fr-FR.json
#	lib/i18n/messages/it-IT.json
#	lib/i18n/messages/nl-NL.json
#	lib/i18n/messages/pt-PT.json

Copy link
Copy Markdown
Owner Author

Shipped — this landed on main in #500 (merge commit f478dce5).

It stayed open only because its base is codex/strategy-home-outcome-localization-20260910, a stacked branch that never moved, so the auto-close-on-merge never applied. Retargeting it to main is refused by GitHub with "There are no new commits between base branch 'main' and head branch 'codex/strategy-home-calendar-readers-20260910'" — which is the confirmation that every commit here is already in main.

Closing as redundant, not rejected.


Generated by Claude Code

This branch was successfully deployed

1 active deployment
Preview — 8557a3a3 Deployed Sep 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant