Repository navigation
Keep all-day briefing events on the right date and expose failed reads - #492
Closed
NewWorldVenture wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 10, 2026
NewWorldVenture
marked this pull request as ready for review
September 10, 2026 11:45
This was referenced Sep 10, 2026
Owner
Author
|
Shipped — this landed on It stayed open only because its base is Closing as redundant, not rejected. Generated by Claude Code |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All-day events now remain on their stored calendar date in daily briefing and morning delivery. Previously, family-local timestamp windows could drop today's holiday, include tomorrow's holiday, display an invented clock time, or report a false overlap. Timed events now use calendar-day boundaries across daylight-saving changes, including midnight gaps and skipped dates; all-day events use separate UTC date bounds before the existing query limits.
The API preserves all_day through projections and engine mapping, uses the existing translated all-day label, and excludes all-day and zero-duration entries from timed conflicts. Required calendar query errors or transport failures return a translated, retryable 503 before optional model work instead of producing an empty-day briefing. Delivery retains its existing failure, deduplication, recipient and quarantine behavior.
Validation:
Stacked on #488 at 2aef85a. #490 supplies the complementary shared-engine zero-duration correction. Existing start-date-only selection, ordering and limits remain; recurrence expansion and multi-day overlap selection are outside this patch. The private date helper serves current/future readers; a historical noncontiguous date such as St. John's 1988 rollback cannot be represented exactly by its single interval. No SQL, dependency, shared navigation or live notification changes. All five required checks passed at exact 4b3c375 in CI run 34471857580. Actual E2E job 102853361012 logs show 428 passes and five unchanged durable-session skips; authenticated and concierge coverage remain enabled. Ready for owner review and integration; production deployment remains separate.