Skip to content

Keep all-day briefing events on the right date and expose failed reads - #492

Closed
NewWorldVenture wants to merge 1 commit into
codex/strategy-first-brief-timezone-20260910from
codex/strategy-briefing-all-day-readers-20260910
Closed

NewWorldVenture wants to merge 1 commit into
codex/strategy-first-brief-timezone-20260910from
codex/strategy-briefing-all-day-readers-20260910

Conversation

@NewWorldVenture

@NewWorldVenture NewWorldVenture commented Sep 10, 2026 •

Copy link
Copy Markdown
Owner

All-day events now remain on their stored calendar date in daily briefing and morning delivery. Previously, family-local timestamp windows could drop today's holiday, include tomorrow's holiday, display an invented clock time, or report a false overlap. Timed events now use calendar-day boundaries across daylight-saving changes, including midnight gaps and skipped dates; all-day events use separate UTC date bounds before the existing query limits.

The API preserves all_day through projections and engine mapping, uses the existing translated all-day label, and excludes all-day and zero-duration entries from timed conflicts. Required calendar query errors or transport failures return a translated, retryable 503 before optional model work instead of producing an empty-day briefing. Delivery retains its existing failure, deduplication, recipient and quarantine behavior.

Validation:

  • Actual-reader baseline reproduced 17 failures across 18 cases; four additional cases reproduced false HTTP 200 responses on failed required reads, and four reproduced midnight-gap boundary errors.
  • 529 relevant tests across 17 suites passed, with TypeScript, scoped lint and all eight i18n gates passing. Independent review reran 324 overlapping tests across eight suites without findings.
  • Tests execute the actual API and delivery readers against in-memory Supabase with real projection/filter/order/limit behavior. They cover family isolation, mixed-row limits, unchanged original timestamps, translated labels, point events, failed reads, and nine timezone membership cases. External auth/service boundaries use controlled doubles; no live provider or database claim is made.
  • Combined rehearsal 474379bcaf3948a220167c313d68b7080dd105f4 passed 385 tests across nine affected suites. Its test-helper conflict resolution retains the earlier nested OR support alongside this patch's strict AND/negation handling; the rehearsal adds positive OR compatibility cases.

Stacked on #488 at 2aef85a. #490 supplies the complementary shared-engine zero-duration correction. Existing start-date-only selection, ordering and limits remain; recurrence expansion and multi-day overlap selection are outside this patch. The private date helper serves current/future readers; a historical noncontiguous date such as St. John's 1988 rollback cannot be represented exactly by its single interval. No SQL, dependency, shared navigation or live notification changes. All five required checks passed at exact 4b3c375 in CI run 34471857580. Actual E2E job 102853361012 logs show 428 passes and five unchanged durable-session skips; authenticated and concierge coverage remain enabled. Ready for owner review and integration; production deployment remains separate.

@vercel

vercel Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
bubaly Ready Ready Preview Sep 10, 2026 11:35am UTC

Request Review

Copy link
Copy Markdown
Owner Author

Shipped — this landed on main in #500 (merge commit f478dce5).

It stayed open only because its base is codex/strategy-first-brief-timezone-20260910, a stacked branch that never moved, so the auto-close-on-merge never applied. Retargeting it to main is refused by GitHub with "There are no new commits between base branch 'main' and head branch 'codex/strategy-briefing-all-day-readers-20260910'" — which is the confirmation that every commit here is already in main.

Closing as redundant, not rejected.


Generated by Claude Code

This branch was successfully deployed

1 active deployment
Preview — 4b3c3751 Deployed Sep 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant