Skip to content

Localize adult authentication prompts and signup divider - #482

Closed
NewWorldVenture wants to merge 1 commit into
codex/strategy-pricing-auth-selection-20260909from
codex/strategy-auth-copy-localization-20260910
Closed

NewWorldVenture wants to merge 1 commit into
codex/strategy-pricing-auth-selection-20260909from
codex/strategy-auth-copy-localization-20260910

Conversation

@NewWorldVenture

@NewWorldVenture NewWorldVenture commented Sep 10, 2026 •

Copy link
Copy Markdown
Owner

Signup's divider was fixed English, and several adult signup/phone prompts used informal German while the surrounding flow uses formal address. Six rendered references now use additive messages in all seven locales. Existing formal French and Portuguese wording is retained, and child-directed login copy remains appropriate to that separate flow.

Stacked on #479 at e54ea9b7; this copy follow-up is 22c81020dabec43c11f8f1600080d386f9b26594. It changes only five Signup references, one PhoneAuth heading and six appended catalogue keys per locale. All 12,715 preceding catalogue values and their order are preserved on this branch. Authentication routing, storage, validation, identifiers and handlers are unchanged.

Validation:

  • 138 existing tests across eight suites pass, along with scoped ESLint, all eight translation gates and diff checks.
  • Independent source review found no actionable issues and passed 203 existing tests across eight overlapping suites; this is not an additional disjoint test total.
  • Actual controlled Chromium passed 56 journeys across seven locales at 320/1280 widths, covering signup, email confirmation, password login and both phone forms. There were no JavaScript errors or external requests. All 22 tested source/style/catalogue fingerprints match the committed source; German narrow-screen and French/Portuguese desktop screenshots were independently inspected.
  • Local integration preserves all 13,185 prior combined catalogue values and appends only these six keys per locale. The full 11,794-test suite and 243-page production build belong to the immediately preceding bcbe500b runtime checkpoint and were not repeated or reassigned to this bounded copy change.

Browser checks use the real auth components, locale provider and styles with controlled navigation and auth transport. They do not establish live authentication or production deployment. Required core, mobile, database, E2E and Vercel checks now pass at this published head in CI run 34466656367. Ready for review.

@vercel

vercel Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
bubaly Ready Ready Preview Sep 10, 2026 10:36am UTC

Request Review

@NewWorldVenture
NewWorldVenture marked this pull request as ready for review September 10, 2026 10:44
NewWorldVenture pushed a commit that referenced this pull request Sep 10, 2026
# Conflicts:
#	app/auth/callback/route.ts
#	lib/i18n/messages/de-DE.json
#	lib/i18n/messages/en-US.json
#	lib/i18n/messages/es-ES.json
#	lib/i18n/messages/fr-FR.json
#	lib/i18n/messages/it-IT.json
#	lib/i18n/messages/nl-NL.json
#	lib/i18n/messages/pt-PT.json
#	lib/supabase/auth.ts
#	tests/i18n-server-boundary.test.ts

Copy link
Copy Markdown
Owner Author

Shipped — this landed on main in #500 (merge commit f478dce5).

It stayed open only because its base is codex/strategy-pricing-auth-selection-20260909, a stacked branch that never moved, so the auto-close-on-merge never applied. Retargeting it to main is refused by GitHub with "There are no new commits between base branch 'main' and head branch 'codex/strategy-auth-copy-localization-20260910'" — which is the confirmation that every commit here is already in main.

One note for the record, since your chain's test file was the sharpest thing in the whole integration: auth-review-selection-routes mocks a signed-in user for every test, which is right for its success paths but made "the next sign-in attempt" accidentally signed-in — colliding with #499's rule that a signed-in visitor is never shown a login page. You had already written the signed-out variant (missing-user), and it was the one case still passing, so that was the form the merge adopted: one signed-out answer queued for the failing call, the later successful sign-in still on the fixture default. Your retryHref (via authScreenHref/resolveAuthSelection) replaced the bare /login?error=auth in app/auth/callback/route.ts.

Closing as redundant, not rejected.


Generated by Claude Code

This branch was successfully deployed

1 active deployment
Preview — 22c81020 Deployed Sep 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant