Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with importlib-metadata on conda py37 #1645

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Fix issue with importlib-metadata on conda py37 #1645

merged 3 commits into from
Feb 22, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented Feb 14, 2023

Motivation

See failing build https://github.com/NeurodataWithoutBorders/pynwb/actions/runs/4170640270

importlib_metadata >= 4 has issues with Python 3.7.
Not quite sure why this problem affects all of a sudden. It is certainly odd that multiple versions of importlib_metadata are installed by conda:

Past snippet ``` The following NEW packages will be INSTALLED: ... importlib-metadata conda-forge/linux-64::importlib-metadata-4.11.4-py37h89c1867_0 importlib_metadata conda-forge/linux-64::importlib_metadata-1.5.0-py37_0 ```
`importlib_metadata` is an alias for `importlib-metadata` (underscore vs hyphen)

In any case, in this PR, the version of importlib_metadata is restricted to <4 for python 3.7.

See also #1427

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #1645 (1fc34fa) into dev (cf0048a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1645   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files          25       25           
  Lines        2535     2535           
  Branches      481      481           
=======================================
  Hits         2315     2315           
  Misses        139      139           
  Partials       81       81           
Flag Coverage Δ
integration 70.49% <ø> (ø)
unit 84.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rly rly requested a review from mavaylon1 February 22, 2023 22:48
@rly rly merged commit 494e288 into dev Feb 22, 2023
@rly rly deleted the fix_conda_py37 branch February 22, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants