Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix miniconda 3.7 CI error #1427

Merged
merged 10 commits into from
Mar 9, 2022
Merged

Fix miniconda 3.7 CI error #1427

merged 10 commits into from
Mar 9, 2022

Conversation

rly
Copy link
Contributor

@rly rly commented Feb 2, 2022

Motivation

The CI for miniconda 3.7 on CircleCI is broken due to an incompatibility between some combination of Python 3.7, tox, virtualenv, and importlib-metadata.

AttributeError: 'dict' object has no attribute 'select'

See also pypa/virtualenv#2174

Fixing this seems to then break the pandas installation. This has yet to be resolved.

This affects both PyNWB and HDMF.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly mentioned this pull request Feb 3, 2022
10 tasks
@bendichter
Copy link
Contributor

@rly this does not appear to work

@skapin
Copy link

skapin commented Feb 17, 2022

Fix version of importmetadata fix the trouble for me

I used
importlib-metadata=1.7.0 importlib_metadata=1.7.0

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #1427 (be09f67) into dev (21524b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1427   +/-   ##
=======================================
  Coverage   77.46%   77.46%           
=======================================
  Files          37       37           
  Lines        2733     2733           
  Branches      455      455           
=======================================
  Hits         2117     2117           
  Misses        535      535           
  Partials       81       81           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21524b3...be09f67. Read the comment docs.

@rly
Copy link
Contributor Author

rly commented Mar 8, 2022

This PR also fixes two other issues:

@rly rly requested a review from oruebel March 8, 2022 18:18
@rly rly merged commit 6cf00a6 into dev Mar 9, 2022
@rly rly deleted the fix/miniconda37 branch March 9, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants