Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waveforms to units table #1330

Merged
merged 11 commits into from
Jan 14, 2021

Conversation

CodyCBakerPhD
Copy link
Collaborator

Motivation

Upstream changes to hdmf now allow us to add jagged waveform data as columns to the unit table. This necessarily accompanies sampling information about the waveform data, such as sampling rate and conversion factor for casting data types that are not in Volts.

How to test the behavior?

spike_times = [1, 2]
wf_data = [[1,2,3], [1,2,3]]  # for instance
nwbfile.add_unit(id=1, spike_times=spike_times, waveforms=wf_data)

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR description clearly describes problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • [NA] Have you included the relevant issue number using #XXX notation where XXX is the issue number?

@bendichter Opening this as a draft to start - was there anything else we wanted added to this PR?

@bendichter bendichter marked this pull request as ready for review January 4, 2021 20:33
@CodyCBakerPhD CodyCBakerPhD marked this pull request as draft January 4, 2021 20:34
@bendichter bendichter marked this pull request as ready for review January 10, 2021 20:47
@bendichter bendichter requested a review from rly January 10, 2021 20:47
Copy link
Contributor

@rly rly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks.

@rly
Copy link
Contributor

rly commented Jan 14, 2021

The failing miniconda36 test is due to a CI configuration issue that will be resolved separately.

@rly rly merged commit 4ae60bc into NeurodataWithoutBorders:dev Jan 14, 2021
@rly rly deleted the add_waveforms_cn branch January 14, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants