Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waveform conversion factor for Units table column #489

Open
CodyCBakerPhD opened this issue Aug 31, 2021 · 1 comment
Open

Waveform conversion factor for Units table column #489

CodyCBakerPhD opened this issue Aug 31, 2021 · 1 comment
Labels
category: proposal proposed enhancements or new features priority: low alternative solution already working and/or relevant to only specific user(s)

Comments

@CodyCBakerPhD
Copy link
Contributor

This topic is very analogous to an older discussion, Issue #273, which culminated in the addition of basic waveform properties of waveform_unit and waveform_rate to the columns of the simple statistics waveform_mean and waveform_sd, which were all that existed at the time. In that discussion, it was a fair point for these simple, scalar statistics to be fixed to units of Volts and remain unscaled by any factor.

With schema Issue #248 and pynwb PR #1330, the Units table was extended to include an entire jagged array as a column for the actual waveform data.

As such, I was hoping we could revisit the topic of including a conversion factor for that column, since right now we would have to write all the data in float (converted) form whereas it is common for it to exist in a more base (usually int16) format with an attached conversion factor, as per the ElectricalSeries schema. For long recordings (that are either included or not included in the same NWBFile), this would save a fair amount of storage space even without using compression (though that is also expected to improve if int data types would be allowed).

cc: @bendichter

@rly
Copy link
Contributor

rly commented Sep 21, 2021

Good idea. This sounds good to me.

@rly rly added category: proposal proposed enhancements or new features priority: low alternative solution already working and/or relevant to only specific user(s) labels Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: proposal proposed enhancements or new features priority: low alternative solution already working and/or relevant to only specific user(s)
Projects
None yet
Development

No branches or pull requests

2 participants