-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create and use testing module, remove builder tests, clean up test code #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1117 +/- ##
=======================================
Coverage 68.09% 68.09%
=======================================
Files 37 37
Lines 2282 2282
Branches 398 398
=======================================
Hits 1554 1554
Misses 659 659
Partials 69 69 Continue to review full report at Codecov.
|
ajtritt
approved these changes
Jan 16, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experimenters
andrelated_publications
being string to tuple/list in the current schema. The validator needs to validate against the schema version used to generate the file. See validator erroneously catches non-vector experimenter and related_publications #1090.hdmf.testing.TestCase
aspynwb.testing.TestCase
insrc/testing/testmap.py
. AddTestMapNWBContainer
andTestMapRoundTrip
andTestDataInterfaceIO
underpynwb.testing.TestCase
. This eliminates the need fortests/integration/ui_write/base.py
NWBFile.experimenter
orNWBFile.related_publications
, automatically make it a tuple.tests/unit/test_core_NWBContainer.py
totests/unit/test_core.py
tests/build_fake_data.py
andtests/build_fake_extension.py
Changes require the latest HDMF.