Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation]: TestMapRoundTrip outdated #1585

Closed
3 tasks done
bendichter opened this issue Nov 9, 2022 · 4 comments · Fixed by #1586
Closed
3 tasks done

[Documentation]: TestMapRoundTrip outdated #1585

bendichter opened this issue Nov 9, 2022 · 4 comments · Fixed by #1586

Comments

@bendichter
Copy link
Contributor

What would you like changed or added to the documentation and why?

This page: http://localhost:63342/pynwb/docs/_build/html/testing/make_roundtrip_test.html#testmaproundtrip describes the TestMapRoundTrip class, but I can't find it in pynwb nor hdmf. Has this been replaced with NWBH5IOMixin?

Do you have any interest in helping write or edit the documentation?

Yes.

Code of Conduct
@bendichter
Copy link
Contributor Author

Yes, it looks like it was:

pynwb/src/pynwb/testing/testh5io.py

Line 31 in c0ad3e7

This code is adapted from hdmf.testing.H5RoundTripMixin.

@bendichter
Copy link
Contributor Author

@rly

@oruebel
Copy link
Contributor

oruebel commented Nov 9, 2022

Digging through the history, I believe this was changed in #1117

@bendichter
Copy link
Contributor Author

OK I'll take a stab at updating it

@bendichter bendichter mentioned this issue Nov 9, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update round trip docs NeurodataWithoutBorders/pynwb
2 participants
@bendichter @oruebel