figures generated by pynml-modchananalysis are saved by default
#327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sanjayankur31 PTAL |
|
@sanjayankur31 who should I ask for review ? |
|
I've just returned from leave, so I'll take a look this week. |
* development: chore(vispy): add note about env var fix(tests): only parse sims in parallel fix(tests): compile mod files before testing test(runners): add new test feat(runners): add general multi command runner wrapper fix: handle cases where args/kwargs are not provided chore: do not re-compile mods in examples folder chore(runners): correct rst in docstring chore(runners): correct documentation formatting chore(runners): correct documentation deps: make ppft a default dep feat(runners): add parallel runner and tests
* development: run generate man in right dir, check cell length update logger output adress comments add -swc in pynml
sanjayankur31
requested changes
Apr 16, 2024
|
@sanjayankur31 I have addressed the comments |
|
Could you quickly regenerate the man page too? |
|
OK, looks good now. We'll merge once the tests all pass. 👏 |
* development: feat(LEMSSimulation): allow using float/str for duration/dt docs(lems): document `generate_lems_file_for_neuroml`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently figures are not saved if
pynml-modchananalysisis used on a.modfileCloses #201