Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Ephys: read events from all streams #1430

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Open Ephys: read events from all streams #1430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions neo/rawio/openephysbinaryrawio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ def explore_folder(dirname, experiment_names=None):
for info in rec_structure["continuous"]:
# when multi Record Node the stream name also contains
# the node name to make it unique
oe_stream_name = Path(info["folder_name"]).name # remove trailing slash
oe_stream_name = info["folder_name"].split("/")[0] # remove trailing slash
if len(node_name) > 0:
stream_name = node_name + "#" + oe_stream_name
else:
Expand Down Expand Up @@ -580,8 +580,13 @@ def explore_folder(dirname, experiment_names=None):
if (root / "events").exists() and len(rec_structure["events"]) > 0:
recording["streams"]["events"] = {}
for info in rec_structure["events"]:
oe_stream_name = Path(info["folder_name"]).name # remove trailing slash
stream_name = node_name + "#" + oe_stream_name
# when multi Record Node the stream name also contains
# the node name to make it unique
oe_stream_name = info["folder_name"].split("/")[0] # remove trailing slash
if len(node_name) > 0:
stream_name = node_name + "#" + oe_stream_name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always a #? I have a feeling something is going to change in the future (because why would people be consistent :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is purely a naming on the NEO side ;) it's always been with the #

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool cool. Sounds good. :)

else:
stream_name = oe_stream_name

event_stream = info.copy()
for name in _possible_event_stream_names:
Expand Down
Loading