-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Ephys: read events from all streams #1430
Conversation
# the node name to make it unique | ||
oe_stream_name = info["folder_name"].split("/")[0] # remove trailing slash | ||
if len(node_name) > 0: | ||
stream_name = node_name + "#" + oe_stream_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's always a #? I have a feeling something is going to change in the future (because why would people be consistent :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is purely a naming on the NEO side ;) it's always been with the #
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool cool. Sounds good. :)
Seems to work insofar as I can load event times from all streams of my test file. There are a bunch of other problems with the durations and timestamps, but I think they're unrelated to this so I'll open new issues for those. |
One thing I will note is that the Neuropixels AP and LFP event channels end up with the same name and ID in the resulting header structure inside the |
Test dataset for the behaviour described in my last comment is available here: https://drive.google.com/file/d/1Hr3-GFOpOkNc1hgXdVr5HTunchQm4enw/view?usp=drive_link |
How would you change the implementation to account for this? Maybe we can merge this one and you can make a PR to fix the other issue? |
Just looking through the code, when the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least from my side this looks good and stops the clobbering. I think improvements could be a separate PR, no?
Fixes #1367
@johnmbarrett could you test it on your side?