Make Engine *V3s handle V3 requests only#5845
Merged
Conversation
9ccf3e9 to
a85346f
Compare
dfcb6bf to
78bd6dd
Compare
78bd6dd to
f856077
Compare
MarekM25
approved these changes
Jun 29, 2023
0830df3 to
fbdf0a9
Compare
f856077 to
f431233
Compare
LukaszRozmej
requested changes
Jul 4, 2023
src/Nethermind/Nethermind.Merge.Plugin/Data/ExecutionPayload.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Merge.Plugin/Data/ExecutionPayload.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Merge.Plugin/Data/ExecutionPayload.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Merge.Plugin/Data/ExecutionPayload.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Merge.Plugin.Test/EngineModuleTests.HelperFunctions.cs
Show resolved
Hide resolved
src/Nethermind/Nethermind.Merge.Plugin/Handlers/GetPayloadHandlerBase.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Merge.Plugin/EngineRpcModule.Cancun.cs
Outdated
Show resolved
Hide resolved
Member
|
If we are going class hierarchy - which we now can and should! - let's use polymorphism. Previous design prevented us from doing that. |
12 tasks
Member
|
Or maybe we shouldn't have class hierarchies in engine API parameter classes? This would make multi-dimensional extensions hard.
Now imagine that for now, Optimism doesn't need 4844 and #5476 fields, but at some point, it starts to need it. It will be hard to model the data classes correctly. Options:
|
MarekM25
reviewed
Jul 14, 2023
src/Nethermind/Nethermind.Merge.Plugin/EngineRpcModule.Cancun.cs
Outdated
Show resolved
Hide resolved
MarekM25
reviewed
Jul 14, 2023
src/Nethermind/Nethermind.Merge.Plugin/Handlers/GetPayloadHandlerBase.cs
Show resolved
Hide resolved
…ermindEth/nethermind into feature/eip-4844-v3-handles-v3-only
src/Nethermind/Nethermind.Merge.Plugin.Test/EngineModuleTests.HelperFunctions.cs
Show resolved
Hide resolved
LukaszRozmej
approved these changes
Jul 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #5596 to be merged
Implements ethereum/execution-apis #418
engine_getPayloadV3,engine_newPayloadV3to handle Cancun payloads only.Changes
-38005: Unsupported fork, when V3 is called for a pre-Cancun payloadTypes of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Requires Cancun fork