Merged
Conversation
flcl42
force-pushed
the
feature/eip-4844-ssz
branch
2 times, most recently
from
8aef27a to
69f61e4
Compare
flcl42
force-pushed
the
feature/eip-4844-gas-calculations
branch
from
66c66e9 to
5c907d8
Compare
flcl42
force-pushed
the
feature/eip-4844-ssz
branch
2 times, most recently
from
29a01a3 to
bb81773
Compare
flcl42
force-pushed
the
feature/eip-4844-gas-calculations
branch
6 times, most recently
from
2a52b0b to
5134688
Compare
flcl42
force-pushed
the
feature/eip-4844-ssz
branch
6 times, most recently
from
3ccb719 to
87c9443
Compare
flcl42
force-pushed
the
feature/eip-4844-gas-calculations
branch
5 times, most recently
from
8977b9a to
ef60301
Compare
flcl42
force-pushed
the
feature/eip-4844-ssz
branch
from
87c9443 to
a3bab50
Compare
flcl42
force-pushed
the
feature/eip-4844-gas-calculations
branch
2 times, most recently
from
f57fc65 to
915ede6
Compare
flcl42
force-pushed
the
feature/eip-4844-gas-calculations
branch
from
645438a to
9913404
Compare
flcl42
force-pushed
the
feature/eip-4844-gas-calculations
branch
from
57a6811 to
6105dfb
Compare
marcindsobczak
approved these changes
Jun 22, 2023
src/Nethermind/Nethermind.Consensus/Processing/BlockProcessor.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Consensus/Validators/BlockValidator.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Consensus/Validators/BlockValidator.cs
Outdated
Show resolved
Hide resolved
flcl42
requested review from
smartprogrammer93
and removed request for
smartprogrammer93
12 tasks
MarekM25
reviewed
Jun 30, 2023
Contributor
MarekM25
left a comment
MarekM25
left a comment
There was a problem hiding this comment.
Added a few comments, most of them minor
| blockHeader.WithdrawalsRoot = rlpStream.DecodeKeccak(); | ||
|
|
||
| if (itemsRemaining == 2 && rlpStream.Position != headerCheck) | ||
| if (itemsRemaining == 3 && rlpStream.Position != headerCheck) |
Contributor
There was a problem hiding this comment.
@Demuirgos be careful after merging this PR and 4788
src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
Show resolved
Hide resolved
src/Nethermind/Nethermind.Consensus/Validators/BlockValidator.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Merge.Plugin/BlockProduction/PostMergeBlockProducer.cs
Show resolved
Hide resolved
MarekM25
approved these changes
Jun 30, 2023
flcl42
force-pushed
the
feature/eip-4844-gas-calculations
branch
from
3e6df34 to
0830df3
Compare
flcl42
force-pushed
the
feature/eip-4844-gas-calculations
branch
from
0830df3 to
fbdf0a9
Compare
LukaszRozmej
reviewed
Jul 5, 2023
...ethermind/Nethermind.Consensus/Processing/BlockProcessor.BlockProductionTransactionPicker.cs
Show resolved
Hide resolved
...ethermind/Nethermind.Consensus/Processing/BlockProcessor.BlockProductionTransactionPicker.cs
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds data gas calculations
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Requires Dencun activated to test