Blob gas info in receipts#5767
Merged
deffrian merged 10 commits intofeature/eip-4844-gas-calculationsfrom Jun 6, 2023
Merged
Conversation
added 3 commits
June 4, 2023 23:43
flcl42
changed the base branch from
feature/eip-4844-v6
to
feature/eip-4844-gas-calculations
added 3 commits
June 5, 2023 19:19
LukaszRozmej
reviewed
Jun 5, 2023
Comment on lines
82
to
89
| UInt256 effectiveGasPrice = t.CalculateEffectiveGasPrice(isEip1559Enabled, block.BaseFeePerGas); | ||
| UInt256? dataGasPrice = null; | ||
| ulong? dataGasUsed = null; | ||
| if (t.SupportsBlobs) | ||
| { | ||
| dataGasPrice = IntrinsicGasCalculator.CalculateDataGasPrice(block.Header, t); | ||
| dataGasUsed = IntrinsicGasCalculator.CalculateDataGas(t); | ||
| } |
Member
There was a problem hiding this comment.
This code seems to get duplicated. Maybe lets calculate TxGasInfo in one call?
Contributor
Author
There was a problem hiding this comment.
You mean something like tx.GetGasInfo()?
|
|
||
| } | ||
|
|
||
| public class TxGasInfo |
Comment on lines
844
to
847
| if (postEip4844) | ||
| blockchainBridge.GetReceiptAndGasInfo(Arg.Any<Keccak>()).Returns((receipt, new(UInt256.One, 2, 3), 0)); | ||
| else | ||
| blockchainBridge.GetReceiptAndGasInfo(Arg.Any<Keccak>()).Returns((receipt, new(UInt256.One), 0)); |
Member
There was a problem hiding this comment.
would prefer blockchainBridge.GetReceiptAndGasInfo(Arg.Any<Keccak>()).Returns((receipt, postEip4844 ? new(UInt256.One, 2, 3) : new(UInt256.One), 0));
added 2 commits
June 5, 2023 22:25
…s' into feature/eip-4844-dataGas # Conflicts: # src/Nethermind/Nethermind.Evm/IntrinsicGasCalculator.cs
LukaszRozmej
approved these changes
Jun 5, 2023
added 2 commits
June 6, 2023 17:28
flcl42
pushed a commit
that referenced
this pull request
Jun 7, 2023
* Blob gas info in receipts * Fix gas price * Fix spaces * Add tests * Supports blobs * Ignore on null * Fix suggestions * Fix build --------- Co-authored-by: Nikita Mescheryakov <deffriann@protonmail.com>
flcl42
pushed a commit
that referenced
this pull request
Jun 12, 2023
* Blob gas info in receipts * Fix gas price * Fix spaces * Add tests * Supports blobs * Ignore on null * Fix suggestions * Fix build --------- Co-authored-by: Nikita Mescheryakov <deffriann@protonmail.com>
flcl42
added a commit
that referenced
this pull request
Jun 30, 2023
* Add data gas calculations * ChainSpecs/BlockProcessing: Fix syncing on Genesis block due to ExcessDataGas mismatch. * TxValidator: Move KZG version check into network wrapper verification. * ExcessData gas on genesis block * Check versioned hash earlier * Remake gas, preview * Fix recursion * Add tests, refactor * Get rid of parent block header finder * Clean up * Clean up checks * Fix tests * Fix header mapping to rpc * Fix data gas calculations * Add safety checks * Fix and improve * Blob gas info in receipts (#5767) * Blob gas info in receipts * Fix gas price * Fix spaces * Add tests * Supports blobs * Ignore on null * Fix suggestions * Fix build --------- Co-authored-by: Nikita Mescheryakov <deffriann@protonmail.com> * Increase data gas limits * Clean up * Add more blob space * Fix tests; clean up * Add tests, refacator * Fix MaxFeePerDataGas affects consensus on low balance * Improve max fee per data gas fix * Fix receipts * Add overflow checks * Fix tests * Fix encoding; improve text; clean up * Add gas fields to the local 4844 network genesis * Refactor BlockValidator * Add additional check --------- Co-authored-by: spencer-tb <spencer@spencertaylorbrown.uk> Co-authored-by: Nikita Mescheryakov <deffriann@proton.me> Co-authored-by: Nikita Mescheryakov <deffriann@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
ethereum/execution-apis#398
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?