Skip to content

fix(xdc): prevent InvalidOperationException in XdcPool.EndRound #10416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewshab3 wants to merge 1 commit into from
Closed

fix(xdc): prevent InvalidOperationException in XdcPool.EndRound #10416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/Nethermind/Nethermind.Xdc/XdcPool.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,24 @@ public void EndRound(ulong round)
{
using var lockRelease = _lock.Acquire();
{
List<(ulong Round, Hash256 Hash)>? keysToRemove = null;
foreach (var key in _items.Keys)
{
if (key.Round <= round && _items.Remove(key, out ArrayPoolList<T> list))
if (key.Round <= round)
{
list?.Dispose();
keysToRemove ??= new List<(ulong, Hash256)>();
keysToRemove.Add(key);
}
}

if (keysToRemove is not null)
{
foreach (var key in keysToRemove)
{
if (_items.Remove(key, out ArrayPoolList<T> list))
{
list?.Dispose();
}
}
}
}
Expand Down