fix(xdc): prevent InvalidOperationException in XdcPool.EndRound#10416
Closed
andrewshab3 wants to merge 1 commit intoNethermindEth:masterfrom
Closed
fix(xdc): prevent InvalidOperationException in XdcPool.EndRound#10416andrewshab3 wants to merge 1 commit intoNethermindEth:masterfrom
andrewshab3 wants to merge 1 commit intoNethermindEth:masterfrom
Conversation
Contributor
Author
|
@LukaszRozmej @ak88 sorry, can you check please? |
Contributor
|
Hi @andrewshab3, current version supports |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The original code iterated over
_items.Keyswhile calling_items.Remove()inside the loop.This causesInvalidOperationException: Collection was modified; enumeration operation may not executeat runtime when any item matches the removal condition.Types of changes
What types of changes does your code introduce?