ArbitrumEthRpcModule tests support #195
Merged
+366
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svlachakis
requested review from
AnkushinDaniil,
damian-orzechowski,
hudem1,
tanishqjasoria and
wurdum
as code owners
Contributor
Author
|
The build failures are unrelated with the changes, have to do with recent changes NethermindEth/nethermind#9232 on the master sync branch in NC that are not present in this repo |
wurdum
approved these changes
Sep 4, 2025
Contributor
There was a problem hiding this comment.
Looks like we get to the point where we start writing tests for tests... 😅
Actually... instead of checking dependencies, it would be correct to check that tests can actually use eth_* APIs. Proving that dependencies are resolved doesn't prove that the module is correctly wired up and we can use it ☝️
Contributor
Author
|
@wurdum Alright, I added a couple of meaningful tests 😄 I'll update the task description also. |
damian-orzechowski
added a commit
that referenced
this pull request
Sep 9, 2025
* Corrected namespaces * Adjust code to latest nm changes * Genesis loader fix * Add worldState scope for PrepareBlock * Cleanup * Making most tests work * Fix precompile execution context Orgin / GrandCaller * Fix stylus origin set * Fix rpc module tests * Test fix * Submodule change * Post merge test fixes * Test fixes - scoped WorldState * Submodule update * build fix for precompiled addresses - still pending implementation * VM tests fix * Spec fix - disable new eips * Register `ArbitrumBlockValidationModule` * Code cleanup * Format whitespace * Cleanup * ArbitrumEthRpcModule tests support (#195) * ArbitrumEthRpcModule tests support --------- Co-authored-by: Pavlo Rytikov <[email protected]> * Formatting * Use decorator instead of `ChainSpecBasedSpecProvider` * Change ISpecProvider resolution * Throw OutOfGasException directly instead of calling static method * NM submodule update and fixes * Test fixes * Update NM submodule to master * Fix ArbitrumChainSpecBasedSpecProvider test * Precompiles override & small fixes on nm-master-sync (#196) * Precompiles override * nuget.config fix * IWorldState Import on ArbGasInfoParserTests.cs * Fixes in ArbGasInfoParserTests.cs * ArbGasInfoParserTests.cs worldState fixes * ArbGasInfoParserTests.cs fixes * Nitpick fixes * submodule update * TrackingWorldState.cs fix * Conflicts fix --------- Co-authored-by: stavrosvl7 <[email protected]> Co-authored-by: Stavros Vlachakis <[email protected]> Co-authored-by: Pavlo Rytikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolve #180