Skip to content

Changes to adjust infrastructure code to latest NM master#186

Merged
damian-orzechowski merged 44 commits intomainfrom
fix/nm-master-sync
Sep 9, 2025
Merged

Changes to adjust infrastructure code to latest NM master#186
damian-orzechowski merged 44 commits intomainfrom
fix/nm-master-sync

Conversation

@damian-orzechowski
Copy link
Collaborator

@damian-orzechowski damian-orzechowski commented Sep 2, 2025

Code changes after changing dependency on NM client to latest master. Please look at NethermindEth/nethermind#9232 for reference of extensibility changes that are to be kept and merged to NM master branch.

Known issues:

Copy link
Contributor

@wurdum wurdum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this one is massive

@damian-orzechowski damian-orzechowski marked this pull request as ready for review September 9, 2025 07:19
Copilot AI review requested due to automatic review settings September 9, 2025 07:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the Arbitrum infrastructure code to align with the latest Nethermind master branch changes. The primary goal is to update dependency references and ensure compatibility with recent Nethermind client modifications.

  • Updates namespace imports from Nethermind.Evm.Tracing.GethStyle to Nethermind.Blockchain.Tracing.GethStyle
  • Migrates from Nethermind.State to Nethermind.Evm.State for state management
  • Removes package source mappings from NuGet configuration files
  • Updates various API signatures and method calls to match new Nethermind interfaces

Reviewed Changes

Copilot reviewed 86 out of 86 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
src/nuget.config Removes package source mapping configuration
src/Nethermind.Arbitrum/Tracing/*.cs Updates tracing namespace imports
src/Nethermind.Arbitrum/Precompiles/*.cs Migrates state and API interface usage
src/Nethermind.Arbitrum/Execution/*.cs Updates transaction processing and block execution
src/Nethermind.Arbitrum/Modules/*.cs Adds IForkInfo parameter to RPC modules
src/Nethermind.Arbitrum/Config/*.cs Simplifies initialization and removes unused code
Test files Adds proper world state scoping and updates test infrastructure
Comments suppressed due to low confidence (1)

src/Nethermind.Arbitrum/Modules/ArbitrumEthModuleFactory.cs:1

  • The constructor parameter changed from ulong? secondsPerSlot to IBlocksConfig blocksConfig, but the parameter name and type annotation don't match. This should be IBlocksConfig blocksConfig) without the ulong? type.
// SPDX-FileCopyrightText: 2025 Demerzel Solutions Limited

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@damian-orzechowski damian-orzechowski enabled auto-merge (squash) September 9, 2025 09:55
@github-actions
Copy link

github-actions bot commented Sep 9, 2025

Code Coverage

Package Line Rate Branch Rate Health
Nethermind.Arbitrum 83% 59%
Summary 83% (5787 / 6986) 59% (1536 / 2617)

Minimum allowed line rate is 60%

@damian-orzechowski damian-orzechowski merged commit 3bba784 into main Sep 9, 2025
9 of 10 checks passed
@damian-orzechowski damian-orzechowski deleted the fix/nm-master-sync branch September 9, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants