Changes to adjust infrastructure code to latest NM master#186
Merged
damian-orzechowski merged 44 commits intomainfrom Sep 9, 2025
Merged
Changes to adjust infrastructure code to latest NM master#186damian-orzechowski merged 44 commits intomainfrom
damian-orzechowski merged 44 commits intomainfrom
Conversation
wurdum
approved these changes
Sep 4, 2025
src/Nethermind.Arbitrum/Execution/ArbitrumOverridableTxProcessingEnv.cs
Outdated
Show resolved
Hide resolved
src/Nethermind.Arbitrum/Genesis/ArbitrumBlockTreeInitializer.cs
Outdated
Show resolved
Hide resolved
src/Nethermind.Arbitrum/Genesis/ArbitrumLoadGenesisBlockStep.cs
Outdated
Show resolved
Hide resolved
src/Nethermind.Arbitrum.Test/Arbos/Programs/StylusProgramsTests.cs
Outdated
Show resolved
Hide resolved
src/Nethermind.Arbitrum.Test/Infrastructure/FullChainSimulationSpecProvider.cs
Show resolved
Hide resolved
* ArbitrumEthRpcModule tests support --------- Co-authored-by: Pavlo Rytikov <pavlo@nethermind.io>
hudem1
approved these changes
Sep 6, 2025
* Precompiles override * nuget.config fix
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the Arbitrum infrastructure code to align with the latest Nethermind master branch changes. The primary goal is to update dependency references and ensure compatibility with recent Nethermind client modifications.
- Updates namespace imports from
Nethermind.Evm.Tracing.GethStyletoNethermind.Blockchain.Tracing.GethStyle - Migrates from
Nethermind.StatetoNethermind.Evm.Statefor state management - Removes package source mappings from NuGet configuration files
- Updates various API signatures and method calls to match new Nethermind interfaces
Reviewed Changes
Copilot reviewed 86 out of 86 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/nuget.config | Removes package source mapping configuration |
| src/Nethermind.Arbitrum/Tracing/*.cs | Updates tracing namespace imports |
| src/Nethermind.Arbitrum/Precompiles/*.cs | Migrates state and API interface usage |
| src/Nethermind.Arbitrum/Execution/*.cs | Updates transaction processing and block execution |
| src/Nethermind.Arbitrum/Modules/*.cs | Adds IForkInfo parameter to RPC modules |
| src/Nethermind.Arbitrum/Config/*.cs | Simplifies initialization and removes unused code |
| Test files | Adds proper world state scoping and updates test infrastructure |
Comments suppressed due to low confidence (1)
src/Nethermind.Arbitrum/Modules/ArbitrumEthModuleFactory.cs:1
- The constructor parameter changed from
ulong? secondsPerSlottoIBlocksConfig blocksConfig, but the parameter name and type annotation don't match. This should beIBlocksConfig blocksConfig)without theulong?type.
// SPDX-FileCopyrightText: 2025 Demerzel Solutions Limited
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/Nethermind.Arbitrum/Precompiles/ArbitrumPrecompileExecutionContext.cs
Show resolved
Hide resolved
src/Nethermind.Arbitrum/Precompiles/ArbitrumPrecompileExecutionContext.cs
Show resolved
Hide resolved
svlachakis
approved these changes
Sep 9, 2025
# Conflicts: # src/Nethermind.Arbitrum.Test/Execution/ArbitrumVirtualMachineTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes after changing dependency on NM client to latest master. Please look at NethermindEth/nethermind#9232 for reference of extensibility changes that are to be kept and merged to NM master branch.
Known issues:
ClearBytes_Always_ClearsStoragetest fail - probably due to changes in NM client - please look here: Clear storage cell / trie without reading cell's value first fails nethermind#9239Recording_Always_CoveredWithTestis OS dependent and fails on Windows - to be fixed in a separate PR